Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193120
Change subject: Add @database tags to formatter tests that use database
......................................................................
Add @database tags to formatter tests that use database
All these tests access the database in some way
and need @database tags.
Change-Id: I48e19a208c6aa91c04b4d82b89ee7a014dfc280f
---
M lib/tests/phpunit/formatters/CommonsLinkFormatterTest.php
M lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterTest.php
M lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
M lib/tests/phpunit/formatters/MonolingualHtmlFormatterTest.php
M lib/tests/phpunit/formatters/PropertyValueSnakFormatterTest.php
M lib/tests/phpunit/formatters/WikibaseValueFormatterBuildersTest.php
6 files changed, 11 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/20/193120/1
diff --git a/lib/tests/phpunit/formatters/CommonsLinkFormatterTest.php
b/lib/tests/phpunit/formatters/CommonsLinkFormatterTest.php
index 8b0cc21..0c47ba9 100644
--- a/lib/tests/phpunit/formatters/CommonsLinkFormatterTest.php
+++ b/lib/tests/phpunit/formatters/CommonsLinkFormatterTest.php
@@ -14,11 +14,12 @@
* @group DataValueExtensions
* @group WikibaseLib
* @group Wikibase
+ * @group Database
*
* @licence GNU GPL v2+
* @author Adrian Lang
*/
-class CommonsLinkFormatterTest extends \PHPUnit_Framework_TestCase {
+class CommonsLinkFormatterTest extends \MediaWikiTestCase {
public function commonsLinkFormatProvider() {
$options = new FormatterOptions();
diff --git a/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterTest.php
b/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterTest.php
index cd1878a..5bff186 100644
--- a/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterTest.php
+++ b/lib/tests/phpunit/formatters/EntityIdHtmlLinkFormatterTest.php
@@ -19,11 +19,12 @@
* @group ValueFormatters
* @group WikibaseLib
* @group Wikibase
+ * @group Database
*
* @licence GNU GPL v2+
* @author Marius Hoch < [email protected] >
*/
-class EntityIdHtmlLinkFormatterTest extends PHPUnit_Framework_TestCase {
+class EntityIdHtmlLinkFormatterTest extends \MediaWikiTestCase {
/**
* @param Term $term
diff --git a/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
b/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
index 559738c..83e9f7f 100644
--- a/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
+++ b/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
@@ -15,11 +15,12 @@
* @group DataValueExtensions
* @group WikibaseLib
* @group Wikibase
+ * @group Database
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
*/
-class MessageSnakFormatterTest extends \PHPUnit_Framework_TestCase {
+class MessageSnakFormatterTest extends \MediaWikiTestCase {
public function testFormatSnak() {
//TODO: Find a better message for testing, one that actually
contains wikitext.
diff --git a/lib/tests/phpunit/formatters/MonolingualHtmlFormatterTest.php
b/lib/tests/phpunit/formatters/MonolingualHtmlFormatterTest.php
index 8ff59ff..a16b93b 100644
--- a/lib/tests/phpunit/formatters/MonolingualHtmlFormatterTest.php
+++ b/lib/tests/phpunit/formatters/MonolingualHtmlFormatterTest.php
@@ -14,11 +14,12 @@
* @group DataValueExtensions
* @group WikibaseLib
* @group Wikibase
+ * @group Database
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
*/
-class MonolingualHtmlFormatterTest extends \PHPUnit_Framework_TestCase {
+class MonolingualHtmlFormatterTest extends \MediaWikiTestCase {
/**
* @dataProvider monolingualHtmlFormatProvider
diff --git a/lib/tests/phpunit/formatters/PropertyValueSnakFormatterTest.php
b/lib/tests/phpunit/formatters/PropertyValueSnakFormatterTest.php
index bead849..1613219 100644
--- a/lib/tests/phpunit/formatters/PropertyValueSnakFormatterTest.php
+++ b/lib/tests/phpunit/formatters/PropertyValueSnakFormatterTest.php
@@ -24,11 +24,12 @@
* @group DataValueExtensions
* @group WikibaseLib
* @group Wikibase
+ * @group Database
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
*/
-class PropertyValueSnakFormatterTest extends \PHPUnit_Framework_TestCase {
+class PropertyValueSnakFormatterTest extends \MediaWikiTestCase {
/**
* @dataProvider constructorErrorsProvider
diff --git
a/lib/tests/phpunit/formatters/WikibaseValueFormatterBuildersTest.php
b/lib/tests/phpunit/formatters/WikibaseValueFormatterBuildersTest.php
index b632e7a..970be2b 100644
--- a/lib/tests/phpunit/formatters/WikibaseValueFormatterBuildersTest.php
+++ b/lib/tests/phpunit/formatters/WikibaseValueFormatterBuildersTest.php
@@ -36,6 +36,7 @@
* @group DataValueExtensions
* @group WikibaseLib
* @group Wikibase
+ * @group Database
*
* @licence GNU GPL v2+
* @author Daniel Kinzler
--
To view, visit https://gerrit.wikimedia.org/r/193120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48e19a208c6aa91c04b4d82b89ee7a014dfc280f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits