jenkins-bot has submitted this change and it was merged.
Change subject: WindowManager: Don't pass 'this' to window factory method
......................................................................
WindowManager: Don't pass 'this' to window factory method
Added in 3ba36b9a (The great and terrible dialog refactor), no longer
needed after 466a8762 (Make content isolation optional) which removed
manager as an argument to window.
This broke things after we allowed Element to accept '$element' as
config parameter in 883678d6 (Implement OO.ui.infuse to reconstitute
PHP widgets in client-side JS).
Bug: T90858
Change-Id: Ifab2aad63d5b9eef64541a332235c8f9ad3fc765
---
M src/WindowManager.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/WindowManager.js b/src/WindowManager.js
index 7600a41..be66ad0 100644
--- a/src/WindowManager.js
+++ b/src/WindowManager.js
@@ -297,7 +297,7 @@
'Cannot auto-instantiate window:
symbolic name is unrecognized by the factory'
) );
} else {
- win = this.factory.create( name, this );
+ win = this.factory.create( name );
this.addWindows( [ win ] );
deferred.resolve( win );
}
--
To view, visit https://gerrit.wikimedia.org/r/193163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifab2aad63d5b9eef64541a332235c8f9ad3fc765
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
