Daniel Kinzler has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193266
Change subject: ParserOptions: added comment regarding editsections usage.
......................................................................
ParserOptions: added comment regarding editsections usage.
// @note: as of Feb 2015, core never sets the editsection flag, since it uses
// <mw:editsection> tags to inject editsections on the fly. However, extensions
// may be using it by calling ParserOption::optionUsed resp.
ParserOutput::registerOption
// directly. At least Wikibase does at this point in time.
Change-Id: Ief95ecb3ae1f5699b788dd3dad0eaf1aa6cc163c
---
M includes/parser/ParserOptions.php
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/66/193266/1
diff --git a/includes/parser/ParserOptions.php
b/includes/parser/ParserOptions.php
index b09fe76..14ceb8d 100644
--- a/includes/parser/ParserOptions.php
+++ b/includes/parser/ParserOptions.php
@@ -792,6 +792,10 @@
$confstr .= $wgRenderHashAppend;
+ // @note: as of Feb 2015, core never sets the editsection flag,
since it uses
+ // <mw:editsection> tags to inject editsections on the fly.
However, extensions
+ // may be using it by calling ParserOption::optionUsed resp.
ParserOutput::registerOption
+ // directly. At least Wikibase does at this point in time.
if ( !in_array( 'editsection', $forOptions ) ) {
$confstr .= '!*';
} elseif ( !$this->mEditSection ) {
--
To view, visit https://gerrit.wikimedia.org/r/193266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief95ecb3ae1f5699b788dd3dad0eaf1aa6cc163c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
