Krinkle has uploaded a new change for review. Change subject: Clean up: Document baseUri, fix test failure. ......................................................................
Clean up: Document baseUri, fix test failure. Base url is now properly documented, in particular as no longer being assumed to have a trailing '?'. Previous code assumed the string had a trailing '?' which was rather unintuitive. Backwards compatibility kept through onSetup hook (to make deployment easier). test.setDefaults has an asynchronous aspect, the test was previously failing (except when the base url was set to null, in which case no request was made and the deferred resolved synchronously). Change-Id: I13f3490ae279e8e85464ad207b5ddbe036e5d95a --- M EventLogging.hooks.php M EventLogging.php M modules/ext.EventLogging.js M tests/ext.EventLogging.tests.js 4 files changed, 42 insertions(+), 34 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging refs/changes/19/33219/1 -- To view, visit https://gerrit.wikimedia.org/r/33219 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I13f3490ae279e8e85464ad207b5ddbe036e5d95a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Krinkle <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
