Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/193565
Change subject: _createQualifiersListview in statementview not just in edit mode
......................................................................
_createQualifiersListview in statementview not just in edit mode
otherwise in code like:
statementview = $.data( this, 'statementview' ),
statement = statementview.value()
the statement value has everything but qualifiers.
this breaks authority control gadget, with qualifiers
never linked.
as always, open to alternatives to this.
Bug: T87858
Change-Id: I812f113de14062a43ab217f31b164367b117ea0c
---
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/65/193565/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index 6f91472..b366f37 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -477,13 +477,12 @@
: this.option( 'predefined' ).mainSnak || null
);
- if( this.isInEditMode() ) {
- this._createQualifiersListview(
- this.options.value
- ?
this.options.value.getClaim().getQualifiers()
- : new wb.datamodel.SnakList()
- );
- }
+ this._createQualifiersListview(
+ this.options.value
+ ? this.options.value.getClaim().getQualifiers()
+ : new wb.datamodel.SnakList()
+ );
+
this._createReferences( this.options.value );
return $.Deferred().resolve().promise();
--
To view, visit https://gerrit.wikimedia.org/r/193565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I812f113de14062a43ab217f31b164367b117ea0c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
