jenkins-bot has submitted this change and it was merged.
Change subject: ve.ce.GeneratedContentNode: Avoid calling $.fn.add, it's slow
......................................................................
ve.ce.GeneratedContentNode: Avoid calling $.fn.add, it's slow
$.fn.add sorts nodes by document order, which for our
purposes is useless and a waste of time.
Change-Id: I7f497931706a6d0d528576d5e09e8a301bf5c8e5
---
M src/ce/nodes/ve.ce.GeneratedContentNode.js
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/nodes/ve.ce.GeneratedContentNode.js
b/src/ce/nodes/ve.ce.GeneratedContentNode.js
index 69a74e8..c759aed 100644
--- a/src/ce/nodes/ve.ce.GeneratedContentNode.js
+++ b/src/ce/nodes/ve.ce.GeneratedContentNode.js
@@ -136,9 +136,8 @@
// Render the computed values of some attributes
for ( i = 0, len = ve.dm.Converter.computedAttributes.length; i < len;
i++ ) {
attr = ve.dm.Converter.computedAttributes[i];
- $rendering.find( '[' + attr + ']' )
- .add( $rendering.filter( '[' + attr + ']' ) )
- .each( resolveAttribute );
+ $rendering.find( '[' + attr + ']' ).each( resolveAttribute );
+ $rendering.filter( '[' + attr + ']' ).each( resolveAttribute );
}
return $rendering.toArray();
--
To view, visit https://gerrit.wikimedia.org/r/193782
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f497931706a6d0d528576d5e09e8a301bf5c8e5
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
