Anomie has submitted this change and it was merged. Change subject: Set default type attribute for button html elements ......................................................................
Set default type attribute for button html elements According to standard the default type for <button> elements is "submit". Depending on compatibility mode IE might use "button", instead. To work around the IE bug this patch forces the standard "submit", if nothing is specified explicitly. See remarks on http://msdn.microsoft.com/en-us/library/ie/ms535211%28v=vs.85%29.aspx : ----- The default value of the type attribute depends on the current document compatibility mode. The default value is submit. In other compatibility modes the default value is button. ... Windows Internet Explorer 8 and later. The default value of the type attribute depends on the current document compatibility mode. In IE8 Standards mode, the default value is submit. In other compatibility modes and earlier versions of Windows Internet Explorer, the default value is button. ----- Change-Id: I3b97a8cac74bbfca63699dfcbf1cc5e9a2cef193 --- M includes/Html.php M tests/phpunit/includes/HtmlTest.php 2 files changed, 18 insertions(+), 8 deletions(-) Approvals: Krinkle: Looks good to me, but someone else must approve Anomie: Verified; Looks good to me, approved Hoo man: Looks good to me, but someone else must approve Matmarex: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/30819 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b97a8cac74bbfca63699dfcbf1cc5e9a2cef193 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Foxtrott <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Daniel Friesen <[email protected]> Gerrit-Reviewer: Foxtrott <[email protected]> Gerrit-Reviewer: Hoo man <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Liangent <[email protected]> Gerrit-Reviewer: Matmarex <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
