jenkins-bot has submitted this change and it was merged.

Change subject: User only requires history access to see the username on a 
revision
......................................................................


User only requires history access to see the username on a revision

Change-Id: I77269c7f14fb9072648b242d563f1cc038efd3be
(cherry picked from commit 47e0a9497bd945ae42eb77b70470829a8ad1929f)
---
M includes/Templating.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Chad: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Templating.php b/includes/Templating.php
index bcdb7fe..b209983 100644
--- a/includes/Templating.php
+++ b/includes/Templating.php
@@ -86,7 +86,7 @@
         * @throws FlowException
         */
        public function getUserLinks( AbstractRevision $revision ) {
-               if ( !$revision->isModerated() && 
!$this->permissions->isAllowed( $revision, 'view' ) ) {
+               if ( !$revision->isModerated() && 
!$this->permissions->isAllowed( $revision, 'history' ) ) {
                        throw new FlowException( 'Insufficient permissions to 
see userlinks for rev_id = ' . $revision->getRevisionId()->getAlphadecimal() );
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/193752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77269c7f14fb9072648b242d563f1cc038efd3be
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: wmf/1.25wmf18
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to