Dr0ptp4kt has submitted this change and it was merged. Change subject: Fix for tap on small images not causing gallery view to appear. ......................................................................
Fix for tap on small images not causing gallery view to appear. To test, go to "Fish" on enwiki, then go to the "Muscular system" section. The swim bladder image will not respond to tap. With this patch it does. Background: We don't want to route tiny chrome images, of which there are many, to our custom data store. The original threshold I had chosen was 100x100, which is too large. (^For an example of a "tiny chrome image" see the "See also" section of the "Fish" article.) The image gallery code assumes that if you are seeing an image, it has been routed to the data store (how else could you tap it if you couldn't see it). With the threshold set to 100x100, images that are large enough to be reasonably expected to be tappable were not being routed to the data store. Change-Id: I510b457d86c2b950f5adb1d8698c554eb73aefd6 --- M wikipedia/Defines/Defines.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dr0ptp4kt: Verified; Looks good to me, approved Fjalapeno: Looks good to me, but someone else must approve Bgerstle: Looks good to me, but someone else must approve diff --git a/wikipedia/Defines/Defines.h b/wikipedia/Defines/Defines.h index 6630a3b..2a7c0b2 100644 --- a/wikipedia/Defines/Defines.h +++ b/wikipedia/Defines/Defines.h @@ -42,7 +42,7 @@ #define HIDE_KEYBOARD_ON_SCROLL_THRESHOLD 55.0f -#define THUMBNAIL_MINIMUM_SIZE_TO_CACHE CGSizeMake(100, 100) +#define THUMBNAIL_MINIMUM_SIZE_TO_CACHE CGSizeMake(35, 35) #define EDIT_SUMMARY_DOCK_DISTANCE_FROM_BOTTOM 68.0f -- To view, visit https://gerrit.wikimedia.org/r/194021 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I510b457d86c2b950f5adb1d8698c554eb73aefd6 Gerrit-PatchSet: 2 Gerrit-Project: apps/ios/wikipedia Gerrit-Branch: master Gerrit-Owner: Mhurd <[email protected]> Gerrit-Reviewer: Bgerstle <[email protected]> Gerrit-Reviewer: Dr0ptp4kt <[email protected]> Gerrit-Reviewer: Fjalapeno <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
