Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/194201
Change subject: Update event logging for Read Next.
......................................................................
Update event logging for Read Next.
Added a "version" parameter to the schema to differentiate between
the old and new style.
Change-Id: I5092a8b7562ebaf543eec97b1db64921d58aa5c5
---
M wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
M
wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
M
wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandlerOld.java
3 files changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/01/194201/1
diff --git
a/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
b/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
index bc72c2b..91e1f80 100644
--- a/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
+++ b/wikipedia/src/main/java/org/wikipedia/analytics/SuggestedPagesFunnel.java
@@ -12,24 +12,27 @@
public class SuggestedPagesFunnel extends Funnel {
private static final String SCHEMA_NAME =
"MobileWikiAppArticleSuggestions";
- private static final int REV_ID = 10590869;
+ private static final int REV_ID = 11448426;
private final String appInstallID;
private final Site site;
+ private final int version;
- public SuggestedPagesFunnel(WikipediaApp app, Site site) {
+ public SuggestedPagesFunnel(WikipediaApp app, Site site, int version) {
super(app, SCHEMA_NAME, REV_ID);
//Retrieve this app installation's unique ID, used to record unique
users of features
appInstallID = app.getAppInstallID();
this.site = site;
+ this.version = version;
}
@Override
protected JSONObject preprocessData(JSONObject eventData) {
try {
eventData.put("appInstallID", appInstallID);
+ eventData.put("version", version);
} catch (JSONException e) {
throw new RuntimeException(e);
}
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
b/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
index 4b5237a..f9ec881 100644
---
a/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
+++
b/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandler.java
@@ -90,7 +90,7 @@
image1 = (ImageViewWithFace)
bottomContentContainer.findViewById(R.id.read_next_image_1);
image1.setOnImageLoadListener(this);
- funnel = new SuggestedPagesFunnel(app, pageTitle.getSite());
+ funnel = new SuggestedPagesFunnel(app, pageTitle.getSite(), 1);
webview.addOnClickListener(new ObservableWebView.OnClickListener() {
@Override
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandlerOld.java
b/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandlerOld.java
index c4c42a0..ba69d51 100644
---
a/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandlerOld.java
+++
b/wikipedia/src/main/java/org/wikipedia/page/bottomcontent/BottomContentHandlerOld.java
@@ -136,7 +136,7 @@
}
});
- funnel = new SuggestedPagesFunnel(app, pageTitle.getSite());
+ funnel = new SuggestedPagesFunnel(app, pageTitle.getSite(), 0);
// preload the display density, since it will be used in a lot of
places
displayDensity = activity.getResources().getDisplayMetrics().density;
--
To view, visit https://gerrit.wikimedia.org/r/194201
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5092a8b7562ebaf543eec97b1db64921d58aa5c5
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
