Hashar has uploaded a new change for review.
Change subject: prevents puppet from restarting Gerrit
......................................................................
prevents puppet from restarting Gerrit
The Gerrit service is subscribed to configuration files which might
changes on each puppet run. The root cause is that we expand a hash to
build the config file and ruby yields elements in some random order. By
sorting the hashes, we make sure puppet will generate a similar file on
each run and thus will no more restart the service :-]
TEST PLAN:
Create a basic configuration file to provide values for template
expansion:
$ cat conf.erb
<%
replication = {
"somehost" => { "url" => "http://localhost";, "threads" => "1" },
"github" => {
"url" => "http://localhost";,
"threads" => "1",
"isGithubRepo" => "true",
},
}
%>
Expand the template:
erb -T '-' conf.erb templates/gerrit/replication.config.erb
Before this patch, the output would vary randomly.
Change-Id: Ie2dd947c5345cdbcb0d7585f16928dbb7a980d2b
---
M templates/gerrit/replication.config.erb
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/21/33321/1
--
To view, visit https://gerrit.wikimedia.org/r/33321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2dd947c5345cdbcb0d7585f16928dbb7a980d2b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
