Kji has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/194375

Change subject: Corrected some HierarchyBuilder functions to be static.
......................................................................

Corrected some HierarchyBuilder functions to be static.

Change-Id: I27f7b5d87c2ce16904c536e4dab525adfff71e65
---
M HierarchyBuilder.class.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/HierarchyBuilder 
refs/changes/75/194375/1

diff --git a/HierarchyBuilder.class.php b/HierarchyBuilder.class.php
index f1231c6..7743197 100644
--- a/HierarchyBuilder.class.php
+++ b/HierarchyBuilder.class.php
@@ -349,7 +349,7 @@
         *
         * @return string: The first page name found within $hierarchyRow.
         */
-       public function getPageNameFromHierarchyRow( $hierarchyRow ) {
+       public static function getPageNameFromHierarchyRow( $hierarchyRow ) {
                $numMatches = preg_match_all( self::PAGENAMEPATTERN, 
$hierarchyRow, $matches );
                // give me the first subpattern match to be the name of the 
previous page
                $pageName = ( $numMatches > 0 ? $matches[1][0] : '' );
@@ -367,7 +367,7 @@
         *
         * @return number: The depth of $hierarchyRow.
         */
-       public function getDepthOfHierarchyRow( $hierarchyRow ) {
+       public static function getDepthOfHierarchyRow( $hierarchyRow ) {
                $numMatches = preg_match_all( self::DEPTHPATTERN, 
$hierarchyRow, $matches );
                $depth = ( $numMatches > 0 ? strlen( $matches[1][0] ) : 0 );
                return $depth;
@@ -681,7 +681,7 @@
         * @return string: The value of the specified property from the given 
page
         *  or the empty string if the property does not exist.
         */
-       public function getPropertyFromPage( $page, $property ) {
+       public static function getPropertyFromPage( $page, $property ) {
                $store = smwfGetStore();
                $title = Title::newFromText( $page );
                $subject = SMWDIWikiPage::newFromTitle( $title );

-- 
To view, visit https://gerrit.wikimedia.org/r/194375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27f7b5d87c2ce16904c536e4dab525adfff71e65
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/HierarchyBuilder
Gerrit-Branch: master
Gerrit-Owner: Kji <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to