jenkins-bot has submitted this change and it was merged.
Change subject: Fix Rubocop AmbiguousRegexpLiteral offenses
......................................................................
Fix Rubocop AmbiguousRegexpLiteral offenses
Change-Id: Id15259df6c914b18543474cf8081f4b9388fe79a
---
M .rubocop_todo.yml
M tests/browser/features/step_definitions/red_link_steps.rb
2 files changed, 3 insertions(+), 7 deletions(-)
Approvals:
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 35e47f7..773883b 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -5,10 +5,6 @@
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 3
-Lint/AmbiguousRegexpLiteral:
- Enabled: false
-
# Offense count: 36
# Configuration parameters: AllowURI, URISchemes.
Metrics/LineLength:
diff --git a/tests/browser/features/step_definitions/red_link_steps.rb
b/tests/browser/features/step_definitions/red_link_steps.rb
index fe09d7c..bf2e430 100644
--- a/tests/browser/features/step_definitions/red_link_steps.rb
+++ b/tests/browser/features/step_definitions/red_link_steps.rb
@@ -41,7 +41,7 @@
page.language_filter_element.send_keys [:enter, "\n"]
page.uls_settings_apply_element.click
page.wait_until do
- @browser.url.match /setlang=#{code}/
+ @browser.url.match(/setlang=#{code}/)
end
end
end
@@ -79,11 +79,11 @@
end
Then(/^the name of the page should appear in the main title$/) do
- on(PageCreationPage).first_heading.should match /Red interlanguage link test/
+ on(PageCreationPage).first_heading.should match(/Red interlanguage link
test/)
end
Then(/^the name "(.+?)" should appear in the main title$/) do |target_title|
- on(PageCreationPage).first_heading.should match /#{target_title}/
+ on(PageCreationPage).first_heading.should match(/#{target_title}/)
end
Then(/^the name of the page should appear in the (.+) column$/) do
|column_type|
--
To view, visit https://gerrit.wikimedia.org/r/194476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id15259df6c914b18543474cf8081f4b9388fe79a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
