jenkins-bot has submitted this change and it was merged.
Change subject: Add more debug logging to UpdateRepoJob
......................................................................
Add more debug logging to UpdateRepoJob
Hopefully this can help me debug why some deletions
aren't propagated properly.
Change-Id: I9b804c57a5b96210c9c758bbea6b88c144ff8306
---
M repo/includes/UpdateRepo/UpdateRepoJob.php
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/UpdateRepo/UpdateRepoJob.php
b/repo/includes/UpdateRepo/UpdateRepoJob.php
index 0329a7d..dc67397 100644
--- a/repo/includes/UpdateRepo/UpdateRepoJob.php
+++ b/repo/includes/UpdateRepo/UpdateRepoJob.php
@@ -134,16 +134,20 @@
} catch ( StorageException $ex ) {
wfDebugLog(
'UpdateRepo',
- __FUNCTION__ . ": EntityRevision not found for
" . $itemId->getSerialization()
+ __FUNCTION__ . ": EntityRevision couldn't be
loaded for " . $itemId->getSerialization() . ": " . $ex->getMessage()
);
- $entityRevision = null;
+ return null;
}
if ( $entityRevision ) {
return $entityRevision->getEntity();
}
+ wfDebugLog(
+ 'UpdateRepo',
+ __FUNCTION__ . ": EntityRevision not found for " .
$itemId->getSerialization()
+ );
return null;
}
@@ -157,6 +161,7 @@
*/
private function saveChanges( Item $item, User $user ) {
$summary = $this->getSummary();
+ $itemId = $item->getId();
$editEntity = new EditEntity(
$this->entityTitleLookup,
@@ -175,11 +180,11 @@
EDIT_UPDATE,
false,
// Don't (un)watch any pages here, as the user didn't
explicitly kick this off
- $this->entityStore->isWatching( $user, $item->getid() )
+ $this->entityStore->isWatching( $user, $itemId )
);
if ( !$status->isOK() ) {
- wfDebugLog( __CLASS__, __FUNCTION__ . ": attemptSave
for " . $item->getId()->getSerialization() . " failed: " .
$status->getMessage()->text() );
+ wfDebugLog( 'UpdateRepo', __FUNCTION__ . ": attemptSave
for " . $itemId->getSerialization() . " failed: " .
$status->getMessage()->text() );
}
return $status->isOK();
--
To view, visit https://gerrit.wikimedia.org/r/194446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b804c57a5b96210c9c758bbea6b88c144ff8306
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
