jenkins-bot has submitted this change and it was merged. Change subject: ParsoidVirtualRESTService: Don't use "else if" ......................................................................
ParsoidVirtualRESTService: Don't use "else if" https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#C_borrowings Change-Id: Ica51fd60e3da75d3b882cf3172ef7500afeab0db --- M includes/libs/virtualrest/ParsoidVirtualRESTService.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Umherirrender: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/libs/virtualrest/ParsoidVirtualRESTService.php b/includes/libs/virtualrest/ParsoidVirtualRESTService.php index 03bdf0d..769cecf 100644 --- a/includes/libs/virtualrest/ParsoidVirtualRESTService.php +++ b/includes/libs/virtualrest/ParsoidVirtualRESTService.php @@ -59,7 +59,7 @@ throw new Exception( "Only 'local' target wiki is currently supported" ); } elseif ( $version !== 'v1' ) { throw new Exception( "Only version 1 exists" ); - } else if ( $reqType !== 'page' && $reqType !== 'transform' ) { + } elseif ( $reqType !== 'page' && $reqType !== 'transform' ) { throw new Exception( "Request type must be either 'page' or 'transform'" ); } -- To view, visit https://gerrit.wikimedia.org/r/193753 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica51fd60e3da75d3b882cf3172ef7500afeab0db Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Legoktm <[email protected]> Gerrit-Reviewer: Umherirrender <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
