jenkins-bot has submitted this change and it was merged. Change subject: Remove rel="archives" from HTML output ......................................................................
Remove rel="archives" from HTML output Follows-up fab055d6a1. Introduced in 4299d27956 (r45988) That link type was removed from HTML5 in 2011. It is not recognized by the W3C Markup Validator. https://html5.org/r/5925 https://www.w3.org/Bugs/Public/show_bug.cgi?id=11486 https://html.spec.whatwg.org/multipage/semantics.html#linkTypes Change-Id: I61ddd7ee3df41bfb62423d0498217d31e7952902 --- M RELEASE-NOTES-1.25 M includes/page/Article.php M includes/skins/SkinTemplate.php 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Krinkle: Looks good to me, approved Jack Phoenix: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/RELEASE-NOTES-1.25 b/RELEASE-NOTES-1.25 index 642fef8..efaaafa 100644 --- a/RELEASE-NOTES-1.25 +++ b/RELEASE-NOTES-1.25 @@ -166,6 +166,8 @@ (instead of returning incorrect results) even when the page ID is known. * (T74070) Duplicate search for archived files on file upload now omits the extension. This requires the fa_sha1 field being populated. +* Removed rel="archives" from the "View history" link, as it did not pass + HTML validation. === Action API changes in 1.25 === * (T67403) XML tag highlighting is now only performed for formats diff --git a/includes/page/Article.php b/includes/page/Article.php index 817b4b6..cc87a10 100644 --- a/includes/page/Article.php +++ b/includes/page/Article.php @@ -1634,7 +1634,7 @@ $context->msg( 'historywarning' )->numParams( $revisions )->parse() . $context->msg( 'word-separator' )->escaped() . Linker::linkKnown( $title, $context->msg( 'history' )->escaped(), - array( 'rel' => 'archives' ), + array(), array( 'action' => 'history' ) ) . '</strong>' ); diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php index 98a1b03..b0390e9 100644 --- a/includes/skins/SkinTemplate.php +++ b/includes/skins/SkinTemplate.php @@ -948,7 +948,6 @@ 'text' => wfMessageFallback( "$skname-view-history", 'history_short' ) ->setContext( $this->getContext() )->text(), 'href' => $title->getLocalURL( 'action=history' ), - 'rel' => 'archives', ); if ( $title->quickUserCan( 'delete', $user ) ) { -- To view, visit https://gerrit.wikimedia.org/r/193670 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61ddd7ee3df41bfb62423d0498217d31e7952902 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: PleaseStand <[email protected]> Gerrit-Reviewer: Daniel Friesen <[email protected]> Gerrit-Reviewer: Jack Phoenix <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
