jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: some minor cleanups in Importer.php
......................................................................
Hygiene: some minor cleanups in Importer.php
Delete missing var; fix some phpdoc
Change-Id: Ia5937e12757129874095e2a0095ebe63af7335e7
---
M includes/Import/Importer.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Import/Importer.php b/includes/Import/Importer.php
index 9d15cfc..5886627 100644
--- a/includes/Import/Importer.php
+++ b/includes/Import/Importer.php
@@ -496,6 +496,8 @@
/**
* @param PageImportState $state
* @return bool True if import completed successfully
+ * @throws ImportSourceStoreException
+ * @throws \Exception
*/
public function import( PageImportState $state ) {
$state->logger->info( 'Importing to ' .
$state->boardWorkflow->getArticleTitle()->getPrefixedText() );
@@ -600,7 +602,7 @@
}
/**
- * @param TopicImportState $pageState
+ * @param TopicImportState $topicState
* @param IImportTopic $importTopic
*/
public function importTopic( TopicImportState $topicState, IImportTopic
$importTopic ) {
@@ -614,7 +616,6 @@
}
$topicState->commitLastModified();
- $topicId = $topicState->topicWorkflow->getId();
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/194588
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5937e12757129874095e2a0095ebe63af7335e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
