Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/194879
Change subject: WIP: Fix regressions RTing some forms of broken list wikitext
......................................................................
WIP: Fix regressions RTing some forms of broken list wikitext
This snippet won't roundtrip
*<small>a
*<small>b
This one won't either:
<small>
*a
*b</small>
But, this one will:
<small>
*a
*b
</small>
The last one will because formatting tags are outside the list and
we have special support for it in our wt2html pipeline (see 600c60b8).
However, the first two are more complex because the formatting markup
is now embedded without the list elts and we let the HTML tree builder
to fix it up.
So, this patch updates the li-handler cleanup from 14c47443 to handle
that.
WIP to get initial opinions ...
Fixes RT-testing regressions.
Change-Id: I71de8faa2e05ec01e13986c618ada362632fef53
---
M lib/wts.TagHandlers.js
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/79/194879/1
diff --git a/lib/wts.TagHandlers.js b/lib/wts.TagHandlers.js
index aa5c15b..e508666 100644
--- a/lib/wts.TagHandlers.js
+++ b/lib/wts.TagHandlers.js
@@ -174,8 +174,12 @@
if (dp.stx !== 'html' && nodeName in listTypes) {
if ( nodeName === 'li' ) {
- parentName =
node.parentNode.nodeName.toLowerCase();
- res = (parentTypes[parentName] || "") + res;
+ var parentNode = node.parentNode;
+ while (!(parentNode.nodeName.toLowerCase() in
parentTypes)) {
+ parentNode = parentNode.parentNode;
+ }
+ parentName = parentNode.nodeName.toLowerCase();
+ res = parentTypes[parentName] + res;
} else {
res = listTypes[nodeName] + res;
}
--
To view, visit https://gerrit.wikimedia.org/r/194879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71de8faa2e05ec01e13986c618ada362632fef53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
