Dr0ptp4kt has submitted this change and it was merged.
Change subject: fix testing target
......................................................................
fix testing target
Change-Id: I2fe617fa1b0d739b627e0575899ba6dc90b96d46
---
M MediaWikiKit/MediaWikiKitTests/MWKImageInfo+MWKImageComparisonTests.m
M Wikipedia.xcodeproj/project.pbxproj
M WikipediaUnitTests/NSString+WMFHTMLParsingTests.m
3 files changed, 53 insertions(+), 101 deletions(-)
Approvals:
Dr0ptp4kt: Verified; Looks good to me, approved
diff --git
a/MediaWikiKit/MediaWikiKitTests/MWKImageInfo+MWKImageComparisonTests.m
b/MediaWikiKit/MediaWikiKitTests/MWKImageInfo+MWKImageComparisonTests.m
index 6e0b64d..e53743a 100644
--- a/MediaWikiKit/MediaWikiKitTests/MWKImageInfo+MWKImageComparisonTests.m
+++ b/MediaWikiKit/MediaWikiKitTests/MWKImageInfo+MWKImageComparisonTests.m
@@ -19,36 +19,32 @@
@implementation MWKImageInfo_MWKImageComparisonTests
-- (MWKImageInfo*)infoAssociatedWithFilename:(NSString*)filename {
- return [[MWKImageInfo alloc] initWithCanonicalPageTitle:[@"File:"
stringByAppendingString:filename]
+- (MWKImageInfo*)infoAssociatedWithSourceURL:(NSString*)imageURL {
+ return [[MWKImageInfo alloc] initWithCanonicalPageTitle:nil
canonicalFileURL:nil
imageDescription:nil
license:nil
filePageURL:nil
- imageURL:nil
+ imageURL:[NSURL
URLWithString:imageURL]
imageThumbURL:nil
owner:nil];
}
-- (MWKImage*)imageAssociatedWithFilename:(NSString*)filename {
- NSString* testFilenameForURL = [filename
stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
- return [[MWKImage alloc] initWithArticle:nil
- sourceURL:[NSString
stringWithFormat:@"foo/%@/440px-%@",
- testFilenameForURL,
testFilenameForURL]];
+- (MWKImage*)imageAssociatedWithSourceURL:(NSString*)imageURL {
+ return [[MWKImage alloc] initWithArticle:nil sourceURL:imageURL];
}
- (void)testAssociation {
- NSString* testFilename = @"some-file name";
- MWKImage* image = [self imageAssociatedWithFilename:testFilename];
- MWKImageInfo* info = [self infoAssociatedWithFilename:testFilename];
+ MWKImage* image = [self
imageAssociatedWithSourceURL:@"some_file_name.jpg/400px-some_file_name.jpg"];
+ MWKImageInfo* info = [self
infoAssociatedWithSourceURL:@"some_file_name.jpg/800px-some_file_name.jpg"];
assertThat(image.infoAssociationValue,
is(equalTo(info.imageAssociationValue)));
XCTAssertTrue([info isAssociatedWithImage:image]);
XCTAssertTrue([image isAssociatedWithInfo:info]);
}
- (void)testDisassociation {
- MWKImage* image = [self imageAssociatedWithFilename:@"some-file name"];
- MWKImageInfo* info = [self infoAssociatedWithFilename:@"other file name"];
+ MWKImage* image = [self
imageAssociatedWithSourceURL:@"some_file_name.jpg/400px-some_file_name.jpg"];
+ MWKImageInfo* info = [self
infoAssociatedWithSourceURL:@"other_file_name.jpg/800px-other_file_name.jpg"];
assertThat([image infoAssociationValue], isNot(equalTo([info
imageAssociationValue])));
XCTAssertFalse([info isAssociatedWithImage:image]);
}
diff --git a/Wikipedia.xcodeproj/project.pbxproj
b/Wikipedia.xcodeproj/project.pbxproj
index a45c9e8..52a520a 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -199,6 +199,27 @@
0EA4402E1AA6281200B09DBA /* NSDateFormatter+WMFExtensions.m in
Sources */ = {isa = PBXBuildFile; fileRef = 0EA4402D1AA6281200B09DBA /*
NSDateFormatter+WMFExtensions.m */; };
701FF5EE601DEA3FCAB7EFD3 /* libPods.a in Frameworks */ = {isa =
PBXBuildFile; fileRef = D82982ED992F47428037BDF2 /* libPods.a */; };
954BA118838BF8BA6B01C34A /* libPods-WikipediaUnitTests.a in
Frameworks */ = {isa = PBXBuildFile; fileRef = 8CE61C6963F825760822A28A /*
libPods-WikipediaUnitTests.a */; };
+ BC0FED621AAA0263002488D7 /* WMFCodingStyle.m in Sources */ =
{isa = PBXBuildFile; fileRef = BC6FEAE01A9B7EFD00A1D890 /* WMFCodingStyle.m */;
};
+ BC0FED631AAA0263002488D7 /* MWKTestCase.m in Sources */ = {isa
= PBXBuildFile; fileRef = BCB669BB1A83F6D300C7B1FE /* MWKTestCase.m */; };
+ BC0FED641AAA0263002488D7 /* MWKArticleStoreTestCase.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669BD1A83F6D300C7B1FE /*
MWKArticleStoreTestCase.m */; };
+ BC0FED661AAA0268002488D7 /* MWKSiteTests.m in Sources */ = {isa
= PBXBuildFile; fileRef = BCB669C91A83F6D300C7B1FE /* MWKSiteTests.m */; };
+ BC0FED671AAA0268002488D7 /* MWKTitleTests.m in Sources */ =
{isa = PBXBuildFile; fileRef = BCB669CA1A83F6D300C7B1FE /* MWKTitleTests.m */;
};
+ BC0FED681AAA0268002488D7 /* MWKUserTests.m in Sources */ = {isa
= PBXBuildFile; fileRef = BCB669CB1A83F6D300C7B1FE /* MWKUserTests.m */; };
+ BC0FED691AAA0268002488D7 /* MWKProtectionStatusTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669CC1A83F6D300C7B1FE /*
MWKProtectionStatusTests.m */; };
+ BC0FED6A1AAA0268002488D7 /* MWKDataStorePathTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BCB669CD1A83F6D300C7B1FE /*
MWKDataStorePathTests.m */; };
+ BC0FED6B1AAA0268002488D7 /* MWKDataStoreStorageTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669CE1A83F6D300C7B1FE /*
MWKDataStoreStorageTests.m */; };
+ BC0FED6C1AAA0268002488D7 /* MWKImageStorageTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BCB669CF1A83F6D300C7B1FE /*
MWKImageStorageTests.m */; };
+ BC0FED6D1AAA0268002488D7 /* MWKHistoryListTests.m in Sources */
= {isa = PBXBuildFile; fileRef = BCB669D01A83F6D300C7B1FE /*
MWKHistoryListTests.m */; };
+ BC0FED6E1AAA0268002488D7 /* MWKImageListTests.m in Sources */ =
{isa = PBXBuildFile; fileRef = BCB66A0F1A851C9B00C7B1FE /* MWKImageListTests.m
*/; };
+ BC0FED6F1AAA0268002488D7 /*
MWKImageInfo+MWKImageComparisonTests.m in Sources */ = {isa = PBXBuildFile;
fileRef = BCB58F7D1A8D1B8400465627 /* MWKImageInfo+MWKImageComparisonTests.m
*/; };
+ BC0FED701AAA026C002488D7 /* NSArray+PredicateTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BC8309C81A7C370B003FC5C7 /*
NSArray+PredicateTests.m */; };
+ BC0FED711AAA026C002488D7 /* WMFJoinedPropertyParametersTests.m
in Sources */ = {isa = PBXBuildFile; fileRef = BC50C3821A83C88F006DC7AF /*
WMFJoinedPropertyParametersTests.m */; };
+ BC0FED721AAA026C002488D7 /* WMFErrorForApiErrorObjectTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669601A83D7B300C7B1FE /*
WMFErrorForApiErrorObjectTests.m */; };
+ BC0FED731AAA026C002488D7 /* NSMutableDictionary+MaybeSetTests.m
in Sources */ = {isa = PBXBuildFile; fileRef = BCB669751A83F59300C7B1FE /*
NSMutableDictionary+MaybeSetTests.m */; };
+ BC0FED741AAA026C002488D7 /* CircularBitwiseRotationTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669FC1A84158200C7B1FE /*
CircularBitwiseRotationTests.m */; };
+ BC0FED751AAA026C002488D7 /* NSArray+BKIndexTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BCB58F7B1A8D0C8E00465627 /*
NSArray+BKIndexTests.m */; };
+ BC0FED761AAA026C002488D7 /* NSString+WMFHTMLParsingTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = C983151B1AA5205700E25EE1 /*
NSString+WMFHTMLParsingTests.m */; };
+ BC0FED771AAA026C002488D7 /* WMFImageURLParsingTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCBDE0AB1AA76EAC006BD29A /*
WMFImageURLParsingTests.m */; };
BC118C0F1A95894D0072E4D8 /* WikipediaAppUtils.m in Sources */ =
{isa = PBXBuildFile; fileRef = C9180EC318AED30C006C1DCA /* WikipediaAppUtils.m
*/; };
BC118C101A9589720072E4D8 /* WMFAssetsFile.m in Sources */ =
{isa = PBXBuildFile; fileRef = 04272E791940EEBC00CC682F /* WMFAssetsFile.m */;
};
BC2CBB8E1AA10F400079A313 /* UIView+WMFFrameUtils.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BC2CBB8D1AA10F400079A313 /*
UIView+WMFFrameUtils.m */; };
@@ -249,27 +270,6 @@
BCB669DD1A83F6D300C7B1FE /* section0.json in Resources */ =
{isa = PBXBuildFile; fileRef = BCB669C61A83F6D300C7B1FE /* section0.json */; };
BCB669DE1A83F6D300C7B1FE /* section1-end.json in Resources */ =
{isa = PBXBuildFile; fileRef = BCB669C71A83F6D300C7B1FE /* section1-end.json
*/; };
BCB66A0C1A85183000C7B1FE /* NSString+WMFHTMLParsing.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB66A0B1A85183000C7B1FE /*
NSString+WMFHTMLParsing.m */; };
- BCBDE0AF1AA76F3F006BD29A /* WMFCodingStyle.m in Sources */ =
{isa = PBXBuildFile; fileRef = BC6FEAE01A9B7EFD00A1D890 /* WMFCodingStyle.m */;
};
- BCBDE0B01AA76F3F006BD29A /* MWKTestCase.m in Sources */ = {isa
= PBXBuildFile; fileRef = BCB669BB1A83F6D300C7B1FE /* MWKTestCase.m */; };
- BCBDE0B11AA76F3F006BD29A /* MWKArticleStoreTestCase.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669BD1A83F6D300C7B1FE /*
MWKArticleStoreTestCase.m */; };
- BCBDE0B21AA76F3F006BD29A /* MWKSiteTests.m in Sources */ = {isa
= PBXBuildFile; fileRef = BCB669C91A83F6D300C7B1FE /* MWKSiteTests.m */; };
- BCBDE0B31AA76F3F006BD29A /* MWKTitleTests.m in Sources */ =
{isa = PBXBuildFile; fileRef = BCB669CA1A83F6D300C7B1FE /* MWKTitleTests.m */;
};
- BCBDE0B41AA76F3F006BD29A /* MWKUserTests.m in Sources */ = {isa
= PBXBuildFile; fileRef = BCB669CB1A83F6D300C7B1FE /* MWKUserTests.m */; };
- BCBDE0B51AA76F3F006BD29A /* MWKProtectionStatusTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669CC1A83F6D300C7B1FE /*
MWKProtectionStatusTests.m */; };
- BCBDE0B61AA76F3F006BD29A /* MWKDataStorePathTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BCB669CD1A83F6D300C7B1FE /*
MWKDataStorePathTests.m */; };
- BCBDE0B71AA76F3F006BD29A /* MWKDataStoreStorageTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669CE1A83F6D300C7B1FE /*
MWKDataStoreStorageTests.m */; };
- BCBDE0B81AA76F3F006BD29A /* MWKImageStorageTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BCB669CF1A83F6D300C7B1FE /*
MWKImageStorageTests.m */; };
- BCBDE0B91AA76F3F006BD29A /* MWKHistoryListTests.m in Sources */
= {isa = PBXBuildFile; fileRef = BCB669D01A83F6D300C7B1FE /*
MWKHistoryListTests.m */; };
- BCBDE0BA1AA76F3F006BD29A /* MWKImageListTests.m in Sources */ =
{isa = PBXBuildFile; fileRef = BCB66A0F1A851C9B00C7B1FE /* MWKImageListTests.m
*/; };
- BCBDE0BB1AA76F3F006BD29A /*
MWKImageInfo+MWKImageComparisonTests.m in Sources */ = {isa = PBXBuildFile;
fileRef = BCB58F7D1A8D1B8400465627 /* MWKImageInfo+MWKImageComparisonTests.m
*/; };
- BCBDE0BC1AA76F3F006BD29A /* NSArray+PredicateTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BC8309C81A7C370B003FC5C7 /*
NSArray+PredicateTests.m */; };
- BCBDE0BD1AA76F3F006BD29A /* WMFJoinedPropertyParametersTests.m
in Sources */ = {isa = PBXBuildFile; fileRef = BC50C3821A83C88F006DC7AF /*
WMFJoinedPropertyParametersTests.m */; };
- BCBDE0BE1AA76F3F006BD29A /* WMFErrorForApiErrorObjectTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669601A83D7B300C7B1FE /*
WMFErrorForApiErrorObjectTests.m */; };
- BCBDE0BF1AA76F3F006BD29A /* NSMutableDictionary+MaybeSetTests.m
in Sources */ = {isa = PBXBuildFile; fileRef = BCB669751A83F59300C7B1FE /*
NSMutableDictionary+MaybeSetTests.m */; };
- BCBDE0C01AA76F3F006BD29A /* CircularBitwiseRotationTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCB669FC1A84158200C7B1FE /*
CircularBitwiseRotationTests.m */; };
- BCBDE0C11AA76F3F006BD29A /* NSArray+BKIndexTests.m in Sources
*/ = {isa = PBXBuildFile; fileRef = BCB58F7B1A8D0C8E00465627 /*
NSArray+BKIndexTests.m */; };
- BCBDE0C21AA76F3F006BD29A /* NSString+WMFHTMLParsingTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = C983151B1AA5205700E25EE1 /*
NSString+WMFHTMLParsingTests.m */; };
- BCBDE0C31AA76F3F006BD29A /* WMFImageURLParsingTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCBDE0AB1AA76EAC006BD29A /*
WMFImageURLParsingTests.m */; };
BCC185D81A9E5628005378F8 /* UILabel+WMFStyling.m in Sources */
= {isa = PBXBuildFile; fileRef = BCC185D71A9E5628005378F8 /*
UILabel+WMFStyling.m */; };
BCC185E01A9EC836005378F8 /* UIButton+FrameUtils.m in Sources */
= {isa = PBXBuildFile; fileRef = BCC185DF1A9EC836005378F8 /*
UIButton+FrameUtils.m */; };
BCC185E81A9FA498005378F8 /*
UICollectionViewFlowLayout+AttributeUtils.m in Sources */ = {isa =
PBXBuildFile; fileRef = BCC185E71A9FA498005378F8 /*
UICollectionViewFlowLayout+AttributeUtils.m */; };
@@ -2782,70 +2782,29 @@
isa = PBXSourcesBuildPhase;
buildActionMask = 2147483647;
files = (
- BCB669611A83D7B300C7B1FE /*
WMFErrorForApiErrorObjectTests.m in Sources */,
- BCB66A101A851C9B00C7B1FE /* MWKImageListTests.m
in Sources */,
- BC6FEAE11A9B7EFD00A1D890 /* WMFCodingStyle.m in
Sources */,
- BCB669FA1A83F71C00C7B1FE /* MWKSectionList.m in
Sources */,
- 042E3B941AA16D6700BF8D66 /*
UIViewController+WMFChildViewController.m in Sources */,
- BCB669631A83DB8F00C7B1FE /*
MWKImageInfoResponseSerializer.m in Sources */,
- BCB669761A83F59300C7B1FE /*
NSMutableDictionary+MaybeSetTests.m in Sources */,
- 0480AE971AA4E65D00A9950C /*
WMFWebViewFooterViewController.m in Sources */,
- BC50C3831A83C88F006DC7AF /*
WMFJoinedPropertyParametersTests.m in Sources */,
- BCB669E01A83F6D300C7B1FE /* MWKTitleTests.m in
Sources */,
- C983151C1AA5205700E25EE1 /*
NSString+WMFHTMLParsingTests.m in Sources */,
- BCB58F451A890D9700465627 /*
MWKImageInfo+MWKImageComparison.m in Sources */,
- BC42735E1A7C73B300068882 /*
NSArray+PredicateTests.m in Sources */,
- BCB669F01A83F71C00C7B1FE /* MWKSavedPageList.m
in Sources */,
- BCB669FD1A84158200C7B1FE /*
CircularBitwiseRotationTests.m in Sources */,
- BC7DFCD71AA4E5FE000035C3 /*
WMFImageURLParsing.m in Sources */,
- BCB669D31A83F6D300C7B1FE /* MWKTestCase.m in
Sources */,
- BCB669E51A83F6D300C7B1FE /*
MWKImageStorageTests.m in Sources */,
- BCB669F51A83F71C00C7B1FE /* MWKImageInfo.m in
Sources */,
- BCB669F71A83F71C00C7B1FE /* MWKArticle.m in
Sources */,
- BCB669F91A83F71C00C7B1FE /* MWKImageList.m in
Sources */,
- BCB669F81A83F71C00C7B1FE /* MWKUserDataStore.m
in Sources */,
- BCB669F31A83F71C00C7B1FE /*
MWKRecentSearchEntry.m in Sources */,
+ BC0FED6D1AAA0268002488D7 /*
MWKHistoryListTests.m in Sources */,
+ BC0FED731AAA026C002488D7 /*
NSMutableDictionary+MaybeSetTests.m in Sources */,
+ BC0FED6E1AAA0268002488D7 /* MWKImageListTests.m
in Sources */,
+ BC0FED701AAA026C002488D7 /*
NSArray+PredicateTests.m in Sources */,
+ BC0FED771AAA026C002488D7 /*
WMFImageURLParsingTests.m in Sources */,
+ BC0FED6B1AAA0268002488D7 /*
MWKDataStoreStorageTests.m in Sources */,
+ BC0FED751AAA026C002488D7 /*
NSArray+BKIndexTests.m in Sources */,
+ BC0FED641AAA0263002488D7 /*
MWKArticleStoreTestCase.m in Sources */,
+ BC0FED6F1AAA0268002488D7 /*
MWKImageInfo+MWKImageComparisonTests.m in Sources */,
+ BC0FED621AAA0263002488D7 /* WMFCodingStyle.m in
Sources */,
+ BC0FED741AAA026C002488D7 /*
CircularBitwiseRotationTests.m in Sources */,
+ BC0FED681AAA0268002488D7 /* MWKUserTests.m in
Sources */,
+ BC0FED661AAA0268002488D7 /* MWKSiteTests.m in
Sources */,
+ BC0FED691AAA0268002488D7 /*
MWKProtectionStatusTests.m in Sources */,
BC118C0F1A95894D0072E4D8 /* WikipediaAppUtils.m
in Sources */,
- BCB669F61A83F71C00C7B1FE /* MWKDataStore.m in
Sources */,
- BCB669E71A83F71C00C7B1FE /* MWKSite.m in
Sources */,
- BCB58F7C1A8D0C8E00465627 /*
NSArray+BKIndexTests.m in Sources */,
- BCB58F7E1A8D1B8400465627 /*
MWKImageInfo+MWKImageComparisonTests.m in Sources */,
- BC50C3841A83C96D006DC7AF /*
WMFNetworkUtilities.m in Sources */,
- BCB669F11A83F71C00C7B1FE /* MWKHistoryEntry.m
in Sources */,
- BC2CBB8F1AA10F400079A313 /*
UIView+WMFFrameUtils.m in Sources */,
- BCB669EB1A83F71C00C7B1FE /* MWKUser.m in
Sources */,
- BCB669ED1A83F71C00C7B1FE /* MWKImage.m in
Sources */,
- 0480AE8C1AA4E61000A9950C /*
WMFOptionsFooterViewController.m in Sources */,
- BCB669E31A83F6D300C7B1FE /*
MWKDataStorePathTests.m in Sources */,
- BCB669E11A83F6D300C7B1FE /* MWKUserTests.m in
Sources */,
- BCB58F791A8D081E00465627 /* NSArray+BKIndex.m
in Sources */,
- BCB669E91A83F71C00C7B1FE /* MWKDataObject.m in
Sources */,
- BCB669EF1A83F71C00C7B1FE /* MWKSavedPageEntry.m
in Sources */,
- BCB669E41A83F6D300C7B1FE /*
MWKDataStoreStorageTests.m in Sources */,
- BCB669D41A83F6D300C7B1FE /*
MWKArticleStoreTestCase.m in Sources */,
- BCB669E81A83F71C00C7B1FE /* MWKTitle.m in
Sources */,
- BCB669E21A83F6D300C7B1FE /*
MWKProtectionStatusTests.m in Sources */,
- 0480AE9D1AA4F01600A9950C /*
WMFWebViewFooterContainerView.m in Sources */,
- 0480AE901AA4E61000A9950C /*
WMFReadMoreViewController.m in Sources */,
- BCB669DF1A83F6D300C7B1FE /* MWKSiteTests.m in
Sources */,
- BCB58F641A8A9F1000465627 /* MWKLicense.m in
Sources */,
- BCB669F21A83F71C00C7B1FE /* MWKHistoryList.m in
Sources */,
- BCB669E61A83F6D300C7B1FE /*
MWKHistoryListTests.m in Sources */,
- BC42735D1A7C73B300068882 /* NSArray+Predicate.m
in Sources */,
+ BC0FED6C1AAA0268002488D7 /*
MWKImageStorageTests.m in Sources */,
+ BC0FED721AAA026C002488D7 /*
WMFErrorForApiErrorObjectTests.m in Sources */,
+ BC0FED711AAA026C002488D7 /*
WMFJoinedPropertyParametersTests.m in Sources */,
+ BC0FED6A1AAA0268002488D7 /*
MWKDataStorePathTests.m in Sources */,
+ BC0FED761AAA026C002488D7 /*
NSString+WMFHTMLParsingTests.m in Sources */,
BC118C101A9589720072E4D8 /* WMFAssetsFile.m in
Sources */,
- BCB669EA1A83F71C00C7B1FE /* MWKSiteDataObject.m
in Sources */,
- 0480AEA11AA4F4DA00A9950C /*
WMFIntrinsicContentSizeAwareTableView.m in Sources */,
- BC86B9411A929D7900B4C039 /*
UICollectionViewFlowLayout+WMFItemSizeThatFits.m in Sources */,
- 0480AE881AA4E61000A9950C /*
WMFLegalFooterViewController.m in Sources */,
- BCB669EC1A83F71C00C7B1FE /* MWKSection.m in
Sources */,
- BCB58F681A8AA22200465627 /*
MWKLicense+ToGlyph.m in Sources */,
- BCB66A0D1A85183000C7B1FE /*
NSString+WMFHTMLParsing.m in Sources */,
- BCB669EE1A83F71C00C7B1FE /*
MWKProtectionStatus.m in Sources */,
- BCB669F41A83F71C00C7B1FE /*
MWKRecentSearchList.m in Sources */,
- BCC185E91A9FA498005378F8 /*
UICollectionViewFlowLayout+AttributeUtils.m in Sources */,
- 04BA48A21A80062F00CB5CAE /* UIFont+WMFStyle.m
in Sources */,
- BCB669741A83F58600C7B1FE /*
NSMutableDictionary+WMFMaybeSet.m in Sources */,
- 042BEAF01A92EE66002CF320 /*
UIWebView+WMFTrackingView.m in Sources */,
+ BC0FED671AAA0268002488D7 /* MWKTitleTests.m in
Sources */,
+ BC0FED631AAA0263002488D7 /* MWKTestCase.m in
Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
diff --git a/WikipediaUnitTests/NSString+WMFHTMLParsingTests.m
b/WikipediaUnitTests/NSString+WMFHTMLParsingTests.m
index 12aec60..698180d 100644
--- a/WikipediaUnitTests/NSString+WMFHTMLParsingTests.m
+++ b/WikipediaUnitTests/NSString+WMFHTMLParsingTests.m
@@ -29,15 +29,12 @@
- (void)testTooShortSnippet {
NSString *string = @"<p>Cat (meow) [cow] too short</p>";
- string = [string wmf_getStringSnippetWithoutHTML];
- XCTAssertNil(string, @"Too short snippet non-nil after parsing");
+ XCTAssertNil([string wmf_getStringSnippetWithoutHTML], @"Too short snippet
non-nil after parsing");
}
- (void)testAdequateSnippet {
NSString *string = @"<p>Dog (woof) [horse] adequately long string</p>";
- string = [string wmf_getStringSnippetWithoutHTML];
- XCTAssertTrue([string isEqualToString:@"Dog adequately long string"],
- @"Parsed snippet didn't match expected");
+ XCTAssertEqualObjects([string wmf_getStringSnippetWithoutHTML], @"Dog
adequately long string");
}
@end
--
To view, visit https://gerrit.wikimedia.org/r/194873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fe617fa1b0d739b627e0575899ba6dc90b96d46
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: Fjalapeno <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
