Cmcmahon has uploaded a new change for review. https://gerrit.wikimedia.org/r/194896
Change subject: QA: add a sleep to make Chrome happy. I don't like it. ...................................................................... QA: add a sleep to make Chrome happy. I don't like it. Since we started using a modern version of Chrome, we have an issue where Selenium clicks the "Show my notifications" link before the javascript that triggers the overlay is in place. Firefox seems to not have the issue, but Chrome does. 'sleep 1' fixes the problem in the smoke test build. We were unable to find a better way, at least for now. Change-Id: Id7fc83186d620cad73050315fd2808f9be5ffad5 --- M tests/browser/features/step_definitions/notification_steps.rb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/96/194896/1 diff --git a/tests/browser/features/step_definitions/notification_steps.rb b/tests/browser/features/step_definitions/notification_steps.rb index 8d547a9..39134eb 100644 --- a/tests/browser/features/step_definitions/notification_steps.rb +++ b/tests/browser/features/step_definitions/notification_steps.rb @@ -1,4 +1,5 @@ When /^I click on the notification icon$/ do + sleep 1 on(ArticlePage).notifications_button_element.when_present.click end -- To view, visit https://gerrit.wikimedia.org/r/194896 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7fc83186d620cad73050315fd2808f9be5ffad5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
