Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/195046
Change subject: ve.ui.Toolbar: Do not remove event listeners in #setup
......................................................................
ve.ui.Toolbar: Do not remove event listeners in #setup
Exactly what it says on the tin. Added in "cf1e1678 Multiple
surface support and demo".
Change-Id: Ib9471bc01132e738c661acc1baf06003e81f69d8
---
M src/ui/ve.ui.Toolbar.js
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/46/195046/1
diff --git a/src/ui/ve.ui.Toolbar.js b/src/ui/ve.ui.Toolbar.js
index 28986d4..cab6919 100644
--- a/src/ui/ve.ui.Toolbar.js
+++ b/src/ui/ve.ui.Toolbar.js
@@ -66,8 +66,6 @@
* @param {ve.ui.Surface} [surface] Surface to attach to
*/
ve.ui.Toolbar.prototype.setup = function ( groups, surface ) {
- this.detach();
-
this.surface = surface;
// Parent method
--
To view, visit https://gerrit.wikimedia.org/r/195046
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9471bc01132e738c661acc1baf06003e81f69d8
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
