jenkins-bot has submitted this change and it was merged.
Change subject: Don't require JavaScript for addHelpLink styles
......................................................................
Don't require JavaScript for addHelpLink styles
And avoid wfMessage.
Followup to 376c0a13df05f30367b2a89c2cac7bdab22600ed
Bug: T45591
Change-Id: I2f02c2a4db609356ff8be30f260490d19f3226d1
---
M includes/OutputPage.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index 33483eb..aa282a7 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -1406,8 +1406,8 @@
* @since 1.25
*/
public function addHelpLink( $to, $overrideBaseUrl = false ) {
- $this->addModules( 'mediawiki.helplink' );
- $text = wfMessage( 'helppage-top-gethelp' )->escaped();
+ $this->addModuleStyles( 'mediawiki.helplink' );
+ $text = $this->msg( 'helppage-top-gethelp' )->escaped();
if ( $overrideBaseUrl ) {
$helpUrl = $to;
--
To view, visit https://gerrit.wikimedia.org/r/195045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f02c2a4db609356ff8be30f260490d19f3226d1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Nemo bis <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
