Ejegg has submitted this change and it was merged. Change subject: Mark test as skipped directly ......................................................................
Mark test as skipped directly No need to throw an exception, if we're already in a PHPUnitTestCase subclass. Change-Id: I04543004c4ae1ca24f45e74a8d13e5d51f40dfd6 --- M sites/all/modules/wmf_civicrm/tests/phpunit/RecurringTest.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ejegg: Looks good to me, approved jenkins-bot: Verified diff --git a/sites/all/modules/wmf_civicrm/tests/phpunit/RecurringTest.php b/sites/all/modules/wmf_civicrm/tests/phpunit/RecurringTest.php index 3ee0635..1ce8fae 100644 --- a/sites/all/modules/wmf_civicrm/tests/phpunit/RecurringTest.php +++ b/sites/all/modules/wmf_civicrm/tests/phpunit/RecurringTest.php @@ -21,7 +21,7 @@ */ public function testNextScheduled( $now, $cycle_day, $expected_next_sched ) { if ( defined( 'HHVM_VERSION' ) ) { - throw new PHPUnit_Framework_SkippedTestError( 'Running under HHVM, skipping known failure' ); + $this->markTestSkipped( 'Running under HHVM, skipping known failure' ); } $msg = array( -- To view, visit https://gerrit.wikimedia.org/r/195053 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04543004c4ae1ca24f45e74a8d13e5d51f40dfd6 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/crm Gerrit-Branch: master Gerrit-Owner: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits