jenkins-bot has submitted this change and it was merged.
Change subject: Tweak to EditorApi to support editing of pages that do not exist
......................................................................
Tweak to EditorApi to support editing of pages that do not exist
Bug: T91858
Change-Id: I849f6f3d87eb119443ef4229594473ce47c44ab2
---
M javascripts/modules/editor/EditorApi.js
1 file changed, 12 insertions(+), 5 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/editor/EditorApi.js
b/javascripts/modules/editor/EditorApi.js
index b0b1f07..6ddde71 100644
--- a/javascripts/modules/editor/EditorApi.js
+++ b/javascripts/modules/editor/EditorApi.js
@@ -54,7 +54,7 @@
options.rvsection = this.sectionId;
}
this.get( options ).done( function ( resp ) {
- var revision;
+ var revision, pageObj;
if ( resp.error ) {
result.reject( resp.error.code
);
@@ -62,14 +62,21 @@
}
// FIXME: MediaWiki API, seriously?
- revision = $.map( resp.query.pages,
function ( page ) {
+ pageObj = $.map( resp.query.pages,
function ( page ) {
return page;
- } )[0].revisions[0];
+ } )[0];
- self.content = revision['*'];
+ // page might not exist and caller
might not have known.
+ // FIXME: API - missing is set to empty
string (face palm)
+ if ( pageObj.missing !== undefined ) {
+ self.content = '';
+ } else {
+ revision = pageObj.revisions[0];
+ self.content = revision['*'];
+ self.timestamp =
revision.timestamp;
+ }
// save content a second time to be
able to check for changes
self.originalContent = self.content;
- self.timestamp = revision.timestamp;
result.resolve( self.content );
} );
--
To view, visit https://gerrit.wikimedia.org/r/195323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I849f6f3d87eb119443ef4229594473ce47c44ab2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
