jenkins-bot has submitted this change and it was merged.
Change subject: Don't flicker "Manage TemplateData" button's disabledness state
......................................................................
Don't flicker "Manage TemplateData" button's disabledness state
The code would call .setDisabled( true ), fire off an API request, and
then always call .setDisabled( false ) when the request finished,
regardless of the response.
Bug: T91324
Change-Id: Iee440a1fca966e0c66669ee5e78b6f5ab8f7f8d6
---
M modules/ext.templateDataGenerator.ui.js
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Mooeypoo: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/ext.templateDataGenerator.ui.js
b/modules/ext.templateDataGenerator.ui.js
index 6f8bbb5..62639ab 100644
--- a/modules/ext.templateDataGenerator.ui.js
+++ b/modules/ext.templateDataGenerator.ui.js
@@ -161,7 +161,6 @@
// Check if there's already a templatedata in a
related page
relatedPage = isDocPage ? parentPage : pageName
+ '/doc';
- editOpenDialogButton.setDisabled( true );
mw.TemplateData.Model.static.getApi(
relatedPage )
.then( function ( result ) {
var msg, matches, content,
@@ -187,7 +186,6 @@
editArea.setNoticeMessage( msg, 'error', true );
}
}
-
editOpenDialogButton.setDisabled( false );
} );
// Prepend to container
--
To view, visit https://gerrit.wikimedia.org/r/195057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee440a1fca966e0c66669ee5e78b6f5ab8f7f8d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
