jenkins-bot has submitted this change and it was merged. Change subject: QA: recent versions of Chrome don't wait for event listeners ......................................................................
QA: recent versions of Chrome don't wait for event listeners The only workaround we've found is a sleep(). I am investigating filing an upstream bug for this. This patch should address the failures seen in https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-SmokeTests-linux-chrome-sauce/49/ However, I have only been able to reproduce the issue locally for notifications.feature. It may also be necessary to add this for language.feature as well, but I haven't done that yet. Change-Id: I0d1aeb5fd1966a9e22890455a1607ae1339d83fe --- M tests/browser/features/step_definitions/editor_steps.rb M tests/browser/features/step_definitions/notification_steps.rb 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Phuedx: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/editor_steps.rb b/tests/browser/features/step_definitions/editor_steps.rb index 7978610..0892c46 100644 --- a/tests/browser/features/step_definitions/editor_steps.rb +++ b/tests/browser/features/step_definitions/editor_steps.rb @@ -3,6 +3,7 @@ end When(/^I click the edit button$/) do + sleep 1 on(ArticlePage).edit_link_element.when_present.click end diff --git a/tests/browser/features/step_definitions/notification_steps.rb b/tests/browser/features/step_definitions/notification_steps.rb index 39134eb..920b0dc 100644 --- a/tests/browser/features/step_definitions/notification_steps.rb +++ b/tests/browser/features/step_definitions/notification_steps.rb @@ -4,6 +4,7 @@ end When(/^I click the notifications overlay close button$/) do + sleep 1 on(ArticlePage).notifications_overlay_close_button_element.when_present.click end -- To view, visit https://gerrit.wikimedia.org/r/195324 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1aeb5fd1966a9e22890455a1607ae1339d83fe Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
