jenkins-bot has submitted this change and it was merged.
Change subject: Remove useless ve-ce-mw*Node classes from GCN subclasses
......................................................................
Remove useless ve-ce-mw*Node classes from GCN subclasses
Since GCN aggressively modifies this.$element, these classes
didn't survive for very long, and they weren't being used
anyway.
Change-Id: I6e9827499374941fbded983956c57cc250d957c8
---
M modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
M modules/ve-mw/ce/nodes/ve.ce.MWGalleryNode.js
2 files changed, 0 insertions(+), 17 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
index 9d681d1..669145c 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
@@ -122,9 +122,6 @@
// Mixin constructors
ve.ce.MWExtensionNode.call( this );
-
- // DOM changes
- this.$element.addClass( 've-ce-mwInlineExtensionNode' );
};
/* Inheritance */
@@ -151,9 +148,6 @@
// Mixin constructors
ve.ce.MWExtensionNode.call( this );
-
- // DOM changes
- this.$element.addClass( 've-ce-mwBlockExtensionNode' );
};
/* Inheritance */
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWGalleryNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWGalleryNode.js
index 26b3a4d..9dab088 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWGalleryNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWGalleryNode.js
@@ -35,17 +35,6 @@
/* Methods */
/**
- * @inheritdoc
- */
-ve.ce.MWGalleryNode.prototype.onSetup = function () {
- // Parent method
- ve.ce.MWGalleryNode.super.prototype.onSetup.call( this );
-
- // DOM changes
- this.$element.addClass( 've-ce-mwGalleryNode' );
-};
-
-/**
* @inheritdoc ve.ce.GeneratedContentNode
*/
ve.ce.MWGalleryNode.prototype.getFocusableElement = function () {
--
To view, visit https://gerrit.wikimedia.org/r/195223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e9827499374941fbded983956c57cc250d957c8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
