jenkins-bot has submitted this change and it was merged.
Change subject: Unbreak cursoring inside table cells
......................................................................
Unbreak cursoring inside table cells
Code for detecting the cursor being adjacent to a table node
didn't exclude table nodes which were being edited, and so was
always fixing up the selection when the cursor was inside a table.
Change-Id: Ifa18938c056467205bb87849f8aeddf0a5866635
(cherry picked from commit b2db809cf37aa1c8197ff8bcb550c7d9e95d9ee0)
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index 5257f3d..cac7061 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -1247,7 +1247,7 @@
} else {
focusNode = node;
}
- return $( focusNode ).closest( '.ve-ce-focusableNode,
.ve-ce-tableNode' ).data( 'view' ) || null;
+ return $( focusNode ).closest( '.ve-ce-focusableNode,
.ve-ce-tableNode:not(.ve-ce-tableNode-editing)' ).data( 'view' ) || null;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/195578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa18938c056467205bb87849f8aeddf0a5866635
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.25wmf20
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
