Matanya has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/195627

Change subject: dynamicproxy: resource attributes quotin
......................................................................

dynamicproxy: resource attributes quotin

bug: T91908
Change-Id: Ie610e23d1a1d45e86bea3246d5d1aa4c18fc5f48
---
M modules/dynamicproxy/manifests/api.pp
M modules/dynamicproxy/manifests/init.pp
2 files changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/27/195627/1

diff --git a/modules/dynamicproxy/manifests/api.pp 
b/modules/dynamicproxy/manifests/api.pp
index 37f948a..b346f90 100644
--- a/modules/dynamicproxy/manifests/api.pp
+++ b/modules/dynamicproxy/manifests/api.pp
@@ -14,7 +14,7 @@
     }
 
     file { '/etc/init/dynamicproxy-api.conf':
-        ensure  => present,
+        ensure  => 'present',
         owner   => 'root',
         group   => 'root',
         mode    => '0444',
@@ -24,7 +24,7 @@
     }
 
     service { 'dynamicproxy-api':
-        ensure  => running,
+        ensure  => 'running',
         enable  => true,
         require => [
             Package['python-invisible-unicorn'],
@@ -65,10 +65,10 @@
     }
 
     cron { 'proxydb-bak':
-            ensure  => present,
+            ensure  => 'present',
             user    => 'root',
-            hour    => 1,
-            minute  => 0,
+            hour    => '1',
+            minute  => '0',
             command => '/usr/local/sbin/proxydb-bak.sh > /dev/null 2>&1',
             require => File['/data/project/backup'],
     }
diff --git a/modules/dynamicproxy/manifests/init.pp 
b/modules/dynamicproxy/manifests/init.pp
index e618238..e0a3f47 100644
--- a/modules/dynamicproxy/manifests/init.pp
+++ b/modules/dynamicproxy/manifests/init.pp
@@ -15,11 +15,11 @@
 class dynamicproxy (
     $ssl_settings,
     $resolver,
-    $redis_maxmemory='512MB',
-    $ssl_certificate_name=false,
-    $notfound_servers=[],
-    $luahandler='domainproxy',
-    $set_xff=false,
+    $redis_maxmemory      = '512MB',
+    $ssl_certificate_name = false,
+    $notfound_servers     = [],
+    $luahandler           = 'domainproxy',
+    $set_xff              = false,
 ) {
     class { '::redis':
         persist       => 'aof',
@@ -41,9 +41,9 @@
     }
 
     file { '/etc/logrotate.d/nginx':
-        ensure => present,
-        owner  => root,
-        group  => root,
+        ensure => 'present',
+        owner  => 'root',
+        group  => 'root',
         mode   => '0444',
         source => 'puppet:///modules/dynamicproxy/logrotate',
     }
@@ -52,14 +52,14 @@
         ensure  => 'file',
         content => template('dynamicproxy/nginx.conf'),
         require => Package['nginx-common'],
-        notify  => Service['nginx']
+        notify  => Service['nginx'],
     }
 
     file { '/etc/security/limits.conf':
         ensure  => 'file',
         source  => 'puppet:///modules/dynamicproxy/limits.conf',
         require => Package['nginx-common'],
-        notify  => Service['nginx']
+        notify  => Service['nginx'],
     }
 
     nginx::site { 'proxy':

-- 
To view, visit https://gerrit.wikimedia.org/r/195627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie610e23d1a1d45e86bea3246d5d1aa4c18fc5f48
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to