Andrew Bogott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/195629

Change subject: Revert "Set keystone tokens to last 30 days."
......................................................................

Revert "Set keystone tokens to last 30 days."

This reverts commit 4ee211149018e718f9cbdfeb9887445a32bdf31a.

Now that tokens in the db are actually working this shouldn't be needed.

bug: T92014
Change-Id: Idf6e358a5edb0eb693812ddb92d6da35a96fa99f
---
M nova/OpenStackNovaController.php
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OpenStackManager 
refs/changes/29/195629/1

diff --git a/nova/OpenStackNovaController.php b/nova/OpenStackNovaController.php
index df8b74b..8a5ab0a 100644
--- a/nova/OpenStackNovaController.php
+++ b/nova/OpenStackNovaController.php
@@ -713,10 +713,10 @@
                $user = $ret['body'];
                $this->token = $this->_get_property( $user->access->token, 'id' 
);
                $key = wfMemcKey( 'openstackmanager', 'fulltoken', $username );
-               // Set a good long expiration time so that it's longer than
-               // MediaWiki's token, so a re-auth will occur
+               // Expiration time is unneccessary. Token expiration is expected
+               // to be longer than MediaWiki's token, so a re-auth will occur
                // before the generic token expires.
-               $wgMemc->set( $key, $this->token, 60*60*24*30 );
+               $wgMemc->set( $key, $this->token );
 
                return $this->token;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/195629
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf6e358a5edb0eb693812ddb92d6da35a96fa99f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to