jenkins-bot has submitted this change and it was merged.
Change subject: ve.init.mw.ViewPageTarget: Recalculate toolbar sizes when
adding "Save" button
......................................................................
ve.init.mw.ViewPageTarget: Recalculate toolbar sizes when adding "Save" button
This really should not be necessary.
Depends on I17d22ba6 in OOjs UI.
Bug: T52227
Change-Id: I024dccb0c1cc24dd8390dd44fb7a2d987eef56ea
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 7679519..35aefe8 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1226,6 +1226,9 @@
.append( this.toolbarSaveButton.$element );
this.toolbar.$actions.append( $actionTools, $pushButtons );
+ // Make the toolbar recalculate its sizes for narrow/wide switching.
+ // This really should not be necessary.
+ this.toolbar.narrowThreshold = this.toolbar.$group.width() +
this.toolbar.$actions.width();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/195049
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I024dccb0c1cc24dd8390dd44fb7a2d987eef56ea
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
