jenkins-bot has submitted this change and it was merged.
Change subject: Fix design issues (spacing and icon position)
......................................................................
Fix design issues (spacing and icon position)
Spacing in heading issues. See phab bug for details
* Spacing of special page
* Description closer to title in collection page
* Split selector Collection page and Special:Gather (made no sense for them to
be under the same selector .collection. Now there is also .collections-list)
* Moved user icon 1px down
Bug: T91634
Change-Id: Ib940ceb942b17ff7ff67b78adb25019d84360ea1
---
M includes/views/CollectionsList.php
M resources/ext.gather.styles/collections.less
2 files changed, 27 insertions(+), 13 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/views/CollectionsList.php
b/includes/views/CollectionsList.php
index 53fd7ab..780aedd 100644
--- a/includes/views/CollectionsList.php
+++ b/includes/views/CollectionsList.php
@@ -48,7 +48,7 @@
* @inheritdoc
*/
public function getHtml() {
- $html = Html::openElement( 'div', array( 'class' => 'collection
content view-border-box' ) );
+ $html = Html::openElement( 'div', array( 'class' =>
'collections-list content view-border-box' ) );
// Get items
$html .= $this->getListItemsHtml( $this->collectionsList );
$html .= Html::closeElement( 'div' );
diff --git a/resources/ext.gather.styles/collections.less
b/resources/ext.gather.styles/collections.less
index 0295dd3..bab7c12 100644
--- a/resources/ext.gather.styles/collections.less
+++ b/resources/ext.gather.styles/collections.less
@@ -17,21 +17,32 @@
}
// FIXME: Bad special page styling defaults.
-#section_0 {
- padding-bottom: 0;
+// Top spacing
+.mw-mf-special #content_wrapper {
+ padding-top: 1em;
}
+// Page heading won't have bottom spacing (to allow possible content to stay
+// close to title if necessary, like a description of the title)
+.mw-mf-special #content_wrapper .pre-content #section_0 {
+ padding-bottom: 0em;
+}
+// Spacing between title and content is defined by the content so that it can
+// be customized
+.content {
+ margin-top: 1.5em;
+}
+// END FIXME: Bad special page styling defaults.
+/*
+ * Collection page
+ */
.collection {
- // Push the content up to be close to the title
- // FIXME: Bad special page styling defaults.
&.content {
- padding-top: 0;
+ // No spacing between title and content (we want meta info of
collection
+ // close to title
+ margin-top: 0;
}
-
- /*
- * Collection page
- */
.collection-header {
text-align: center;
@@ -52,6 +63,7 @@
vertical-align: top;
width: 1.7em;
min-width: 1.7em;
+ margin-top: 1px;
}
}
@@ -130,11 +142,13 @@
}
}
}
+}
- /*
- * List of collections
- */
+/*
+ * List of collections
+ */
+.collections-list {
@overlayHeight: 6em;
--
To view, visit https://gerrit.wikimedia.org/r/195884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib940ceb942b17ff7ff67b78adb25019d84360ea1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
