Matanya has uploaded a new change for review.
https://gerrit.wikimedia.org/r/195743
Change subject: extdist: resource attributes quoting
......................................................................
extdist: resource attributes quoting
bug: T91908
Change-Id: I32eaa286b3b9eca711e83187d762269220fa2c99
---
M modules/extdist/manifests/init.pp
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/43/195743/1
diff --git a/modules/extdist/manifests/init.pp
b/modules/extdist/manifests/init.pp
index 51be2c0..f2f7dbb 100644
--- a/modules/extdist/manifests/init.pp
+++ b/modules/extdist/manifests/init.pp
@@ -5,13 +5,13 @@
#
class extdist(
$base_dir = '/srv',
- $log_path = '/var/log/extdist') {
-
- $dist_dir = "${base_dir}/dist"
- $clone_dir = "${base_dir}/extdist"
- $src_path = "${base_dir}/src"
+ $log_path = '/var/log/extdist'
+) {
+ $dist_dir = "${base_dir}/dist"
+ $clone_dir = "${base_dir}/extdist"
+ $src_path = "${base_dir}/src"
$composer_dir = "${base_dir}/composer"
- $pid_folder = '/run/extdist'
+ $pid_folder = '/run/extdist'
$ext_settings = {
'API_URL' => 'https://www.mediawiki.org/w/api.php',
@@ -34,32 +34,32 @@
}
user { 'extdist':
- ensure => present,
+ ensure => 'present',
system => true,
}
file { '/home/extdist':
- ensure => directory,
+ ensure => 'directory',
owner => 'extdist',
require => User['extdist']
}
file { $log_path:
- ensure => present,
+ ensure => 'present',
owner => 'extdist',
group => 'www-data',
require => User['extdist']
}
file { [$dist_dir, $clone_dir, $src_path, $pid_folder, $composer_dir]:
- ensure => directory,
+ ensure => 'directory',
owner => 'extdist',
group => 'www-data',
mode => '0755',
}
git::clone {'labs/tools/extdist':
- ensure => latest,
+ ensure => 'latest',
directory => $clone_dir,
branch => 'master',
require => [File[$clone_dir], User['extdist']],
@@ -82,14 +82,14 @@
}
file { '/etc/extdist.conf':
- ensure => present,
+ ensure => 'present',
content => ordered_json($ext_settings),
owner => 'extdist',
require => User['extdist']
}
file { '/etc/skindist.conf':
- ensure => present,
+ ensure => 'present',
content => ordered_json($skin_settings),
owner => 'extdist',
require => User['extdist']
--
To view, visit https://gerrit.wikimedia.org/r/195743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I32eaa286b3b9eca711e83187d762269220fa2c99
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
