jenkins-bot has submitted this change and it was merged.
Change subject: Replace $.unique with simpleArrayUnion
......................................................................
Replace $.unique with simpleArrayUnion
$.unique is intended for DOM elements and doesn't work reliably with
strings across browsers. Use simpleArrayUnion with the second list
empty to achieve the same result.
TODO: Provide an actual unique method upstream in OOJS core.
Change-Id: I77722b9ea6fdc354f56f693d95a4b815ec0a8570
---
M src/dm/ve.dm.ClassAttributeNode.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/dm/ve.dm.ClassAttributeNode.js
b/src/dm/ve.dm.ClassAttributeNode.js
index ed24e5c..f5cf9c9 100644
--- a/src/dm/ve.dm.ClassAttributeNode.js
+++ b/src/dm/ve.dm.ClassAttributeNode.js
@@ -94,8 +94,9 @@
if (
attributes.originalClasses &&
ve.compare(
- $.unique( attributes.originalClasses.trim().split(
/\s+/ ) ).sort(),
- $.unique( classNames ).sort()
+ // OO.simpleArrayUnion( x, [] ) makes 'x' a unique array
+ OO.simpleArrayUnion(
attributes.originalClasses.trim().split( /\s+/ ), [] ).sort(),
+ OO.simpleArrayUnion( classNames, [] ).sort()
)
) {
return attributes.originalClasses;
--
To view, visit https://gerrit.wikimedia.org/r/195959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77722b9ea6fdc354f56f693d95a4b815ec0a8570
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
