Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196208
Change subject: Disable JSCS requireSpaceAfterLineComment
......................................................................
Disable JSCS requireSpaceAfterLineComment
This is exactly the type of completely over-the-top, completely irrelevant
rule that makes me go nuts. Blocking (!) a patch with a -2 (!) because of
semantically irrelevant whitespace (!) in semantically irrelevant single-line
comments (!). What on earth? We have several hundrets (!) of single-line
comments with no space in our code base. Most of them in PHP. We may disagree
if such comments are good-practice (I ommit the space if the comment is
behind some code and add it if the comment is on it's own line). But this is
not an error and not a reason to waste peoples time.
Change-Id: I239a8e9089887ca73dcd1f2bc1ce0d1ab112ffc9
---
M .jscsrc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/08/196208/1
diff --git a/.jscsrc b/.jscsrc
index 06dac8b..913e342 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -60,7 +60,7 @@
"requireCapitalizedConstructors": true,
"requireDotNotation": true,
"disallowYodaConditions": true,
- "requireSpaceAfterLineComment": true,
+ "requireSpaceAfterLineComment": false,
"disallowNewlineBeforeBlockStatements": true,
"validateQuoteMarks": "'",
--
To view, visit https://gerrit.wikimedia.org/r/196208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I239a8e9089887ca73dcd1f2bc1ce0d1ab112ffc9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
