Dr0ptp4kt has submitted this change and it was merged.
Change subject: Addresses Bug:T90606 Now using different url parameters for
sharing types.
......................................................................
Addresses Bug:T90606 Now using different url parameters for sharing types.
Change-Id: I7acd9345f7ff9cdd45432b397e163c4af8c43168
---
M wikipedia/View Controllers/ShareCard/WMFShareOptionsViewController.m
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Dr0ptp4kt: Looks good to me, approved
diff --git a/wikipedia/View
Controllers/ShareCard/WMFShareOptionsViewController.m b/wikipedia/View
Controllers/ShareCard/WMFShareOptionsViewController.m
index 74beee7..2e07b0e 100644
--- a/wikipedia/View Controllers/ShareCard/WMFShareOptionsViewController.m
+++ b/wikipedia/View Controllers/ShareCard/WMFShareOptionsViewController.m
@@ -25,7 +25,6 @@
@property (strong, nonatomic) UIView* grayOverlay;
@property (strong, nonatomic) WMFShareOptionsView* shareOptions;
@property (strong, nonatomic) UIImage* shareImage;
-@property (strong, nonatomic) NSURL* desktopURL;
@property (strong, nonatomic) NSString* shareTitle;
@property (strong, nonatomic) UIPopoverController* popover;
@@ -58,10 +57,7 @@
}
self = [super init];
if (self) {
- _desktopURL = [[NSURL alloc] initWithString:[NSString
stringWithFormat:@"%@%@",
-
article.title.desktopURL.absoluteString,
- @"?source=app"]];
- if (!_desktopURL) {
+ if (!article.title.desktopURL.absoluteString) {
NSLog(@"Could not retrieve desktop URL for article.");
return nil;
}
@@ -262,7 +258,13 @@
}
- (void)transferSharingToDelegate {
- NSMutableArray* activityItems = @[self.shareTitle,
self.desktopURL].mutableCopy;
+ NSString* parameter = self.shareImage ? @"wprov=sfii1" : @"wprov=sfti1";
+
+ NSURL* url = [[NSURL alloc] initWithString:[NSString
stringWithFormat:@"%@?%@",
+
self.article.title.desktopURL.absoluteString,
+ parameter]];
+
+ NSMutableArray* activityItems = @[self.shareTitle, url].mutableCopy;
if (self.shareImage) {
[activityItems addObject:self.shareImage];
}
--
To view, visit https://gerrit.wikimedia.org/r/196243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7acd9345f7ff9cdd45432b397e163c4af8c43168
Gerrit-PatchSet: 2
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno <[email protected]>
Gerrit-Reviewer: Bgerstle <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: Mhurd <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
