Ssmith has submitted this change and it was merged.
Change subject: Fix board nav links
......................................................................
Fix board nav links
Change-Id: I4b11ac67ded6d256661b8e1b1be740fee7ea1ba5
---
M src/components/app-content/app-content.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ssmith: Looks good to me, approved
diff --git a/src/components/app-content/app-content.js
b/src/components/app-content/app-content.js
index dce8604..49b3c65 100644
--- a/src/components/app-content/app-content.js
+++ b/src/components/app-content/app-content.js
@@ -42,7 +42,7 @@
var pages = ['Library', 'Profile', 'Home'], view = data.target.id;
if( pages.indexOf(data.target.id) > -1 ){
self.displayPage(view);
- } else if( typeof view !== 'number' ) {
+ } else if( isNaN( parseInt( view, 10 ) ) ) {
self.displayPage($.trim($(data.target).text()));
} else {
$.get('board/' + view, function( bdata ){
--
To view, visit https://gerrit.wikimedia.org/r/195979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b11ac67ded6d256661b8e1b1be740fee7ea1ba5
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
