Jeroen De Dauw has submitted this change and it was merged. Change subject: SMW 1.9: Create SMW\Highlighter class ......................................................................
SMW 1.9: Create SMW\Highlighter class ## Description + Move smwfContextHighlighter into SMW\Highlighter class + Use SMW namespace + Rename some options parameter to avoid naming confusion + Remove all styling information from the calling enities and put them into the SMW\Highlighter class itself Of course one could create a class per entity type but does this really make sense just to grab some configuration parameters? ## Patch sets +3 Add HighlighterTest, GlobalFunctionsTest, use constants, docs++ Change-Id: I955e3b081caa8a708c6a05a2cd07e6136fdbae0c --- M SemanticMediaWiki.hooks.php A includes/Highlighter.php M includes/SMW_GlobalFunctions.php M includes/SMW_Setup.php M includes/datavalues/SMW_DV_Number.php M includes/datavalues/SMW_DV_Property.php M includes/datavalues/SMW_DV_String.php M resources/Resources.php M resources/ext.smw.util.tooltip.js A tests/phpunit/includes/GlobalFunctionsTest.php A tests/phpunit/includes/HighlighterTest.php 11 files changed, 449 insertions(+), 81 deletions(-) Approvals: Mwjames: Verified Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32012 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I955e3b081caa8a708c6a05a2cd07e6136fdbae0c Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: 1.9.x Gerrit-Owner: Mwjames <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Markus Kroetzsch <[email protected]> Gerrit-Reviewer: Mwjames <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
