Wctaiwan has submitted this change and it was merged. Change subject: Fix strict standards warning in MassMessageServerSideJob ......................................................................
Fix strict standards warning in MassMessageServerSideJob Bug: T92650 Change-Id: I5d369f03ac6aa8be50d5b50254e691d6cdfef9c3 --- M MassMessage.i18n.magic.php M includes/job/MassMessageServerSideJob.php 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Wctaiwan: Looks good to me, approved diff --git a/MassMessage.i18n.magic.php b/MassMessage.i18n.magic.php index 967b59a..cc4e93e 100644 --- a/MassMessage.i18n.magic.php +++ b/MassMessage.i18n.magic.php @@ -2,6 +2,7 @@ /** * Internationalization file. */ +// @codingStandardsIgnoreFile $magicWords = array(); @@ -78,4 +79,4 @@ /** Simplified Chinese (中文(简体)) */ $magicWords['zh-hans'] = array( 'target' => array( 0, '目标' ), -); \ No newline at end of file +); diff --git a/includes/job/MassMessageServerSideJob.php b/includes/job/MassMessageServerSideJob.php index a5dd56e..fb5dad7 100644 --- a/includes/job/MassMessageServerSideJob.php +++ b/includes/job/MassMessageServerSideJob.php @@ -25,10 +25,10 @@ /** * Don't add any hidden comments - * + * @param $stripTildes bool ignored * @return string */ - function makeText() { + function makeText( $stripTildes = false ) { return $this->params['message']; } } -- To view, visit https://gerrit.wikimedia.org/r/196615 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d369f03ac6aa8be50d5b50254e691d6cdfef9c3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MassMessage Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: Wctaiwan <wctai...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits