jenkins-bot has submitted this change and it was merged.
Change subject: Make special page input fields wide and responsive
......................................................................
Make special page input fields wide and responsive
The "size" attributes are almost pointless if there is a CSS width
defined, which is the case. Removing it makes the code simpler and
easier to maintain.
Browsers default is 40, by the way.
I'm also making the fields much wider (and responsive, which wasn't
the case before), which is relevant for label, description and alias
fields.
Change-Id: Idd798402dac7df27ecf4e7dd56ff4f5b3ad35af4
---
M repo/includes/specials/SpecialModifyTerm.php
M repo/includes/specials/SpecialNewEntity.php
M repo/includes/specials/SpecialNewItem.php
M repo/includes/specials/SpecialSetLabelDescriptionAliases.php
M repo/includes/specials/SpecialSetSiteLink.php
M repo/resources/wikibase.special/wikibase.special.css
6 files changed, 5 insertions(+), 8 deletions(-)
Approvals:
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/specials/SpecialModifyTerm.php
b/repo/includes/specials/SpecialModifyTerm.php
index c40dc69..bf304c5 100644
--- a/repo/includes/specials/SpecialModifyTerm.php
+++ b/repo/includes/specials/SpecialModifyTerm.php
@@ -206,7 +206,6 @@
array(
'class' => 'wb-input',
'id' => 'wb-modifyterm-value',
- 'size' => 50
)
)
. Html::element( 'br' );
diff --git a/repo/includes/specials/SpecialNewEntity.php
b/repo/includes/specials/SpecialNewEntity.php
index 258ff9c..615068a 100644
--- a/repo/includes/specials/SpecialNewEntity.php
+++ b/repo/includes/specials/SpecialNewEntity.php
@@ -226,7 +226,6 @@
'text',
array(
'id' => 'wb-newentity-label',
- 'size' => 12,
'class' => 'wb-input',
'lang' => $this->contentLanguage->getCode(),
'dir' => $this->contentLanguage->getDir(),
@@ -250,7 +249,6 @@
'text',
array(
'id' => 'wb-newentity-description',
- 'size' => 36,
'class' => 'wb-input',
'lang' => $this->contentLanguage->getCode(),
'dir' => $this->contentLanguage->getDir(),
diff --git a/repo/includes/specials/SpecialNewItem.php
b/repo/includes/specials/SpecialNewItem.php
index 2e8cee3..fa4497f 100644
--- a/repo/includes/specials/SpecialNewItem.php
+++ b/repo/includes/specials/SpecialNewItem.php
@@ -112,7 +112,6 @@
'text',
array(
'id' => 'wb-newitem-site',
- 'size' => 12,
'class' => 'wb-input',
'readonly' => 'readonly'
)
@@ -131,7 +130,6 @@
'text',
array(
'id' => 'wb-newitem-page',
- 'size' => 12,
'class' => 'wb-input',
'readonly' => 'readonly'
)
diff --git a/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
b/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
index 8c5a058..95ecfe6 100644
--- a/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
+++ b/repo/includes/specials/SpecialSetLabelDescriptionAliases.php
@@ -185,7 +185,6 @@
array(
'class' => 'wb-input',
'id' => $fieldId,
- 'size' => 50,
)
);
}
diff --git a/repo/includes/specials/SpecialSetSiteLink.php
b/repo/includes/specials/SpecialSetSiteLink.php
index 7518284..512c14b 100644
--- a/repo/includes/specials/SpecialSetSiteLink.php
+++ b/repo/includes/specials/SpecialSetSiteLink.php
@@ -221,7 +221,6 @@
array(
'class' => 'wb-input wb-input-text',
'id' => 'wb-setsitelink-page',
- 'size' => 50
)
);
diff --git a/repo/resources/wikibase.special/wikibase.special.css
b/repo/resources/wikibase.special/wikibase.special.css
index 143accd..f5c9e68 100644
--- a/repo/resources/wikibase.special/wikibase.special.css
+++ b/repo/resources/wikibase.special/wikibase.special.css
@@ -24,8 +24,12 @@
}
.wb-input, .wb-select {
+ -webkit-box-sizing: border-box;
+ -moz-box-sizing: border-box;
+ box-sizing: border-box;
margin-bottom: 1em;
- width: 25em;
+ max-width: 65em; /* similar to .wikibase-entityview */
+ width: 100%;
}
.wb-button {
--
To view, visit https://gerrit.wikimedia.org/r/195266
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd798402dac7df27ecf4e7dd56ff4f5b3ad35af4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
