jenkins-bot has submitted this change and it was merged.
Change subject: TabIndexedElement: Clarify description
......................................................................
TabIndexedElement: Clarify description
Change-Id: I0238947ebf622abf88624344cee7a34fab0fd965
---
M i18n/is.json
M i18n/krc.json
M i18n/tr.json
M src/Dialog.js
M src/Window.js
M src/elements/TabIndexedElement.js
6 files changed, 48 insertions(+), 18 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/i18n/is.json b/i18n/is.json
index 2c99bdd..3a4e145 100644
--- a/i18n/is.json
+++ b/i18n/is.json
@@ -7,5 +7,14 @@
},
"ooui-outline-control-move-down": "Færa atriði niður",
"ooui-outline-control-move-up": "Færa atriði upp",
- "ooui-toolbar-more": "Fleira"
+ "ooui-outline-control-remove": "Fjarlægja atriði",
+ "ooui-toolbar-more": "Fleira",
+ "ooui-toolgroup-expand": "Fleira",
+ "ooui-toolgroup-collapse": "Færra",
+ "ooui-dialog-message-accept": "Í lagi",
+ "ooui-dialog-message-reject": "Hætta við",
+ "ooui-dialog-process-error": "Eitthvað mistókst",
+ "ooui-dialog-process-dismiss": "Loka",
+ "ooui-dialog-process-retry": "Reyna aftur",
+ "ooui-dialog-process-continue": "Halda áfram"
}
diff --git a/i18n/krc.json b/i18n/krc.json
index 1bec097..ef92e49 100644
--- a/i18n/krc.json
+++ b/i18n/krc.json
@@ -7,5 +7,13 @@
"ooui-outline-control-move-down": "Элементни тюбюне кёчюр",
"ooui-outline-control-move-up": "Элементни башына кёчюр",
"ooui-outline-control-remove": "Пунктну кетер",
- "ooui-toolbar-more": "Энтда"
+ "ooui-toolbar-more": "Энтда",
+ "ooui-toolgroup-expand": "Энтда",
+ "ooui-toolgroup-collapse": "Артха",
+ "ooui-dialog-message-accept": "OK",
+ "ooui-dialog-message-reject": "Ызына ал",
+ "ooui-dialog-process-error": "Не эсе да табсыз кетди",
+ "ooui-dialog-process-dismiss": "Джаб",
+ "ooui-dialog-process-retry": "Энтда сынаб кёр",
+ "ooui-dialog-process-continue": "Бардыр"
}
diff --git a/i18n/tr.json b/i18n/tr.json
index c9d0999..7b4d492 100644
--- a/i18n/tr.json
+++ b/i18n/tr.json
@@ -14,8 +14,14 @@
},
"ooui-outline-control-move-down": "Ögeyi aşağı taşı",
"ooui-outline-control-move-up": "Ögeyi yukarı taşı",
+ "ooui-outline-control-remove": "Ögeyi kaldır",
"ooui-toolbar-more": "Dahası",
"ooui-toolgroup-expand": "Dahası",
"ooui-toolgroup-collapse": "Daha az",
- "ooui-dialog-process-retry": "Tekrar dene"
+ "ooui-dialog-message-accept": "Tamam",
+ "ooui-dialog-message-reject": "İptal",
+ "ooui-dialog-process-error": "Bir şeyler yanlış gitti",
+ "ooui-dialog-process-dismiss": "Kapat",
+ "ooui-dialog-process-retry": "Tekrar dene",
+ "ooui-dialog-process-continue": "Devam et"
}
diff --git a/src/Dialog.js b/src/Dialog.js
index 65c13cd..0ef7b11 100644
--- a/src/Dialog.js
+++ b/src/Dialog.js
@@ -211,9 +211,10 @@
* @inheritdoc
*
* @param {Object} [data] Dialog opening data
- * @param {jQuery|string|Function|null} [data.title] Dialog title, omit to use
#static-title
- * @param {Object[]} [data.actions] List of OO.ui.ActionWidget configuration
options for each
- * action item, omit to use #static-actions
+ * @param {jQuery|string|Function|null} [data.title] Dialog title, omit to use
+ * the {@link #static-title static title}
+ * @param {Object[]} [data.actions] List of configuration options for each
+ * {@link OO.ui.ActionWidget action widget}, omit to use {@link
#static-actions static actions}.
*/
OO.ui.Dialog.prototype.getSetupProcess = function ( data ) {
data = data || {};
diff --git a/src/Window.js b/src/Window.js
index e22c7f9..55e0a85 100644
--- a/src/Window.js
+++ b/src/Window.js
@@ -403,9 +403,10 @@
};
/**
- * Set window dimensions.
+ * Set window dimensions. This method is called by the {@link
OO.ui.WindowManager window manager}
+ * when the window is opening. In general, setDimensions should not be called
directly.
*
- * Properties are applied to the frame container.
+ * To set the size of the window, use the #setSize method.
*
* @param {Object} dim CSS dimension properties
* @param {string|number} [dim.width] Width
diff --git a/src/elements/TabIndexedElement.js
b/src/elements/TabIndexedElement.js
index 70b3ef9..96d4aa7 100644
--- a/src/elements/TabIndexedElement.js
+++ b/src/elements/TabIndexedElement.js
@@ -29,9 +29,12 @@
*
* @constructor
* @param {Object} [config] Configuration options
- * @cfg {jQuery} [$tabIndexed] tabIndexed node, assigned to #$tabIndexed, omit
to use #$element
- * @cfg {number|null} [tabIndex=0] Tab index value. Use 0 to use default
ordering, use -1 to
- * prevent tab focusing, use null to suppress the `tabindex` attribute.
+ * @cfg {jQuery} [$tabIndexed] The element that should use the tabindex
functionality. By default,
+ * the functionality is applied to the element created by the class
($element). If a different element is specified, the tabindex
+ * functionality will be applied to it instead.
+ * @cfg {number|null} [tabIndex=0] Number that specifies the element’s
position in the tab-navigation
+ * order (e.g., 1 for the first focusable element). Use 0 to use the default
navigation order; use -1
+ * to remove the element from the tab-navigation flow.
*/
OO.ui.TabIndexedElement = function OoUiTabIndexedElement( config ) {
// Configuration initialization
@@ -56,11 +59,13 @@
/* Methods */
/**
- * Set the element with `tabindex` attribute.
+ * Set the element that should use the tabindex functionality.
*
- * If an element is already set, it will be cleaned up before setting up the
new element.
+ * This method is used to retarget a tabindex mixin so that its functionality
applies
+ * to the specified element. If an element is currently using the
functionality, the mixin’s
+ * effect on that element is removed before the new element is set up.
*
- * @param {jQuery} $tabIndexed Element to set tab index on
+ * @param {jQuery} $tabIndexed Element that should use the tabindex
functionality
* @chainable
*/
OO.ui.TabIndexedElement.prototype.setTabIndexedElement = function (
$tabIndexed ) {
@@ -74,9 +79,9 @@
};
/**
- * Set tab index value.
+ * Set the value of the tabindex.
*
- * @param {number|null} tabIndex Tab index value or null for no tab index
+ * @param {number|null} tabIndex Tabindex value, or `null` for no tabindex
* @chainable
*/
OO.ui.TabIndexedElement.prototype.setTabIndex = function ( tabIndex ) {
@@ -123,9 +128,9 @@
};
/**
- * Get tab index value.
+ * Get the value of the tabindex.
*
- * @return {number|null} Tab index value
+ * @return {number|null} Tabindex value
*/
OO.ui.TabIndexedElement.prototype.getTabIndex = function () {
return this.tabIndex;
--
To view, visit https://gerrit.wikimedia.org/r/197241
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0238947ebf622abf88624344cee7a34fab0fd965
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Kmenger <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
