Spage has submitted this change and it was merged. Change subject: Use semicolon as query string terminator ......................................................................
Use semicolon as query string terminator Semicolons are permitted by the specs -- see: http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 Literal semicolons in keys or values are encoded to %3B by JavaScript's encodeURIComponent, jQuery's $.param, and PHP's http_build_query. The use of semicolons as line terminators is visually familiar. Change-Id: I633eda0a8f381e2bac96bfdf76b3a771b8bb4589 --- M EventLogging.hooks.php M modules/ext.EventLogging.js 2 files changed, 15 insertions(+), 8 deletions(-) Approvals: Mattflaschen: Looks good to me, but someone else must approve Spage: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33307 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I633eda0a8f381e2bac96bfdf76b3a771b8bb4589 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
