jenkins-bot has submitted this change and it was merged.
Change subject: Don't try to remove stuff we never added
......................................................................
Don't try to remove stuff we never added
When we're in insertion mode, we don't haven't done anything yet,
so when we teardown the inspector we need not remove anything.
Bug: T93011
Change-Id: I8dddfd679baa01a947cb47e1255f1d39afd812fb
---
M src/ui/inspectors/ve.ui.AnnotationInspector.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/inspectors/ve.ui.AnnotationInspector.js
b/src/ui/inspectors/ve.ui.AnnotationInspector.js
index 3164d6d..b507dd7 100644
--- a/src/ui/inspectors/ve.ui.AnnotationInspector.js
+++ b/src/ui/inspectors/ve.ui.AnnotationInspector.js
@@ -243,7 +243,10 @@
fragment = surfaceModel.getFragment(
this.initialSelection, false ),
selection = this.getFragment().getSelection();
- if ( !( selection instanceof ve.dm.LinearSelection ) ) {
+ if (
+ !( selection instanceof ve.dm.LinearSelection )
||
+ ( remove && selection.getRange().isCollapsed() )
+ ) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/197426
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dddfd679baa01a947cb47e1255f1d39afd812fb
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
