Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197490
Change subject: ocg: Move defaults to class params, rather than hiera
......................................................................
ocg: Move defaults to class params, rather than hiera
Sane defaults should be in the class itself as default params.
Bug: T91555
Change-Id: I7e7cd1a3a20611bb866e05418474a004da8ffa82
---
D hieradata/common/ocg/nagios.yaml
M modules/ocg/manifests/nagios.pp
2 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/90/197490/1
diff --git a/hieradata/common/ocg/nagios.yaml b/hieradata/common/ocg/nagios.yaml
deleted file mode 100644
index 92e3286..0000000
--- a/hieradata/common/ocg/nagios.yaml
+++ /dev/null
@@ -1,4 +0,0 @@
-wjs: 800000
-cjs: 1500000
-wrj: 500
-crj: 3000
diff --git a/modules/ocg/manifests/nagios.pp b/modules/ocg/manifests/nagios.pp
index c5e6e46..9de4188 100644
--- a/modules/ocg/manifests/nagios.pp
+++ b/modules/ocg/manifests/nagios.pp
@@ -2,10 +2,10 @@
# Sets up icinga alerts for an Offline Content Generator instance.
#
class ocg::nagios (
- $wjs, # warning job status queue messages i.e. 20000
- $cjs, # critical job status queue messages i.e. 30000
- $wrj, # warning render jobs queue messages i.e. 100
- $crj, # critical render jobs queue messages i.e. 500
+ $wjs = 800000, # warning job status queue messages i.e. 20000
+ $cjs = 1500000 , # critical job status queue messages i.e. 30000
+ $wrj = 500, # warning render jobs queue messages i.e. 100
+ $crj = 3000, # critical render jobs queue messages i.e. 500
$url = 'http://localhost:8000/?command=health', # OCG health check URL
) {
--
To view, visit https://gerrit.wikimedia.org/r/197490
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e7cd1a3a20611bb866e05418474a004da8ffa82
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
