Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/197527

Change subject: Improve appearance on RTL
......................................................................

Improve appearance on RTL

* Tag message content with language and direction.
* Tag message title with ltr direction
* Align to line-start with CSS

Change-Id: Iecbf709a9f82367dbf824ad6e0864e0d9b052db2
---
M resources/css/ext.translate.special.searchtranslations.css
M specials/SpecialSearchTranslations.php
2 files changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/27/197527/1

diff --git a/resources/css/ext.translate.special.searchtranslations.css 
b/resources/css/ext.translate.special.searchtranslations.css
index b827847..29a617d 100644
--- a/resources/css/ext.translate.special.searchtranslations.css
+++ b/resources/css/ext.translate.special.searchtranslations.css
@@ -68,11 +68,13 @@
 }
 
 .tux-searchpage .results .tux-text {
+       text-align: left;
        font-size: 16px;
        padding-top: 20px;
 }
 
 .tux-searchpage .results .tux-title {
+       text-align: left;
        color: #555;
 }
 
diff --git a/specials/SpecialSearchTranslations.php 
b/specials/SpecialSearchTranslations.php
index 1336f43..c5fc1c1 100644
--- a/specials/SpecialSearchTranslations.php
+++ b/specials/SpecialSearchTranslations.php
@@ -152,11 +152,21 @@
                        }
 
                        $titleText = $title->getPrefixedText();
+                       $titleAttribs = array(
+                               'class' => 'row tux-title',
+                               'dir' => 'ltr',
+                       );
+
+                       $textAttribs = array(
+                               'class' => 'row tux-text',
+                               'lang' => wfBCP47( $document['language'] ),
+                               'dir' => Language::factory( 
$document['language'] )->getDir(),
+                       );
 
                        $resultsHtml = $resultsHtml
                                . Html::openElement( 'div', $resultAttribs )
-                               . Html::rawElement( 'div', array( 'class' => 
'row tux-text' ), $text )
-                               . Html::element( 'div', array( 'class' => 'row 
tux-title' ), $titleText )
+                               . Html::rawElement( 'div', $textAttribs, $text )
+                               . Html::element( 'div', $titleAttribs, 
$titleText )
                                . $edit
                                . Html::closeElement( 'div' );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/197527
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecbf709a9f82367dbf824ad6e0864e0d9b052db2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to