jenkins-bot has submitted this change and it was merged.
Change subject: Drop not needed @dataProvider doc tags from
MediaWikiTitleCodecTest
......................................................................
Drop not needed @dataProvider doc tags from MediaWikiTitleCodecTest
No other @dataProvider in this file does have it's parameters documented.
We usually don't do this because it doesn't add useful information and
is not possible in all cases anyway, e.g. in providers for tests that
are expected to fail. The @param tags would be "mixed" there.
Change-Id: I12a44482e7934a4a18d284d57bf510cb0467cee3
---
M tests/phpunit/includes/title/MediaWikiTitleCodecTest.php
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/title/MediaWikiTitleCodecTest.php
b/tests/phpunit/includes/title/MediaWikiTitleCodecTest.php
index f1146a7..860fec4 100644
--- a/tests/phpunit/includes/title/MediaWikiTitleCodecTest.php
+++ b/tests/phpunit/includes/title/MediaWikiTitleCodecTest.php
@@ -370,13 +370,6 @@
/**
* @dataProvider provideGetNamespaceName
- *
- * @param int $namespace
- * @param string $text
- * @param string $lang
- * @param string $expected
- *
- * @internal param \TitleValue $title
*/
public function testGetNamespaceName( $namespace, $text, $lang,
$expected ) {
$codec = $this->makeCodec( $lang );
--
To view, visit https://gerrit.wikimedia.org/r/197643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12a44482e7934a4a18d284d57bf510cb0467cee3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
