Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/197832

Change subject: ci-settings: Update environment variable test
......................................................................

ci-settings: Update environment variable test

Follows-up 96da4e3.

Also use test -n instead of the ancient "x" hack.
This script specifically runs in bash from the hashbang.

Change-Id: I64737277ecdcbba48498c8f7e52564d0dbcbfcd2
---
M bin/ci-settings.sh
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/32/197832/1

diff --git a/bin/ci-settings.sh b/bin/ci-settings.sh
index 98b1fce..4c42d4f 100644
--- a/bin/ci-settings.sh
+++ b/bin/ci-settings.sh
@@ -1,11 +1,7 @@
 #!/bin/bash
 
-if [ "x${JOB_NAME}" = "x" ]; then
-       echo "JOB_NAME environment variable was not set, exiting."
-       exit 1
-fi
-if [ "x${BUILD_NUMBER}" = "x" ]; then
-       echo "BUILD_NUMBER environment variable was not set, exiting."
+if [ -n "$BUILD_TAG" ]; then
+       echo "BUILD_TAG environment variable was not set, exiting."
        exit 1
 fi
 

-- 
To view, visit https://gerrit.wikimedia.org/r/197832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64737277ecdcbba48498c8f7e52564d0dbcbfcd2
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to