Dzahn has submitted this change and it was merged.

Change subject: wikimania_scholarships: resource attributes quoting and minor 
lint
......................................................................


wikimania_scholarships: resource attributes quoting and minor lint

Bug: T91908
Change-Id: I6fbabebb0eda9fd7c028dd9c42662c9dd402ca90
---
M modules/wikimania_scholarships/manifests/init.pp
1 file changed, 16 insertions(+), 15 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/wikimania_scholarships/manifests/init.pp 
b/modules/wikimania_scholarships/manifests/init.pp
index 776033b..9d31aea 100644
--- a/modules/wikimania_scholarships/manifests/init.pp
+++ b/modules/wikimania_scholarships/manifests/init.pp
@@ -64,23 +64,24 @@
         content => template('wikimania_scholarships/apache.conf.erb'),
     }
 
-    file {
-        $deploy_dir:
-            ensure  => directory;
+    file { $deploy_dir:
+        ensure  => directory,
+    }
 
-        "${deploy_dir}/.env":
-            ensure  => present,
-            mode    => '0444',
-            owner   => 'root',
-            group   => 'root',
-            notify  => Service['apache2'],
-            content => template('wikimania_scholarships/env.erb');
+    file { "${deploy_dir}/.env":
+        ensure  => present,
+        mode    => '0444',
+        owner   => 'root',
+        group   => 'root',
+        notify  => Service['apache2'],
+        content => template('wikimania_scholarships/env.erb'),
+    }
 
-        $cache_dir:
-            ensure => directory,
-            mode   => '0755',
-            owner  => 'www-data',
-            group  => 'root';
+    file { $cache_dir:
+        ensure => directory,
+        mode   => '0755',
+        owner  => 'www-data',
+        group  => 'root',
     }
 
     include ::apache::mod::rewrite

-- 
To view, visit https://gerrit.wikimedia.org/r/195864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fbabebb0eda9fd7c028dd9c42662c9dd402ca90
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Matanya <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to