Adrian Lang has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197872
Change subject: Remove simple delegating method EntityChange::getEntityType
......................................................................
Remove simple delegating method EntityChange::getEntityType
Change-Id: I9a9ea9a1a9bbbb2321eb7f85f81c0cf8b2e3e1c5
---
M client/includes/Changes/ChangeHandler.php
M lib/includes/changes/EntityChange.php
2 files changed, 1 insertion(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/72/197872/1
diff --git a/client/includes/Changes/ChangeHandler.php
b/client/includes/Changes/ChangeHandler.php
index 4bc65bc..236f6f0 100644
--- a/client/includes/Changes/ChangeHandler.php
+++ b/client/includes/Changes/ChangeHandler.php
@@ -334,7 +334,7 @@
//@todo: add getFields() to the interface, or provide getters!
$fields = $change->getFields();
- $fields['entity_type'] = $change->getEntityType();
+ $fields['entity_type'] =
$change->getEntityId()->getEntityType();
if ( $change instanceof ItemChange ) {
$rcinfo['comment'] = $this->getEditComment( $change );
diff --git a/lib/includes/changes/EntityChange.php
b/lib/includes/changes/EntityChange.php
index d287e87..a23ac69 100644
--- a/lib/includes/changes/EntityChange.php
+++ b/lib/includes/changes/EntityChange.php
@@ -66,14 +66,6 @@
}
/**
- * @return string
- */
- public function getEntityType() {
- $id = $this->getEntityId();
- return $id->getEntityType();
- }
-
- /**
* @return EntityId
*/
public function getEntityId() {
--
To view, visit https://gerrit.wikimedia.org/r/197872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a9ea9a1a9bbbb2321eb7f85f81c0cf8b2e3e1c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
