jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused EntityChange::setEntityId
......................................................................
Remove unused EntityChange::setEntityId
Change-Id: Ife61209174ef964a45ac768ef54b94ca64031020
---
M lib/includes/changes/EntityChange.php
M lib/tests/phpunit/changes/EntityChangeTest.php
2 files changed, 0 insertions(+), 18 deletions(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/changes/EntityChange.php
b/lib/includes/changes/EntityChange.php
index d287e87..043cc79 100644
--- a/lib/includes/changes/EntityChange.php
+++ b/lib/includes/changes/EntityChange.php
@@ -227,13 +227,6 @@
}
/**
- * @param EntityId $id
- */
- public function setEntityId( EntityId $id ) {
- $this->setField( 'object_id', $id->getSerialization() );
- }
-
- /**
* @param int $userId
*
* @todo Merge into future setUserInfo.
diff --git a/lib/tests/phpunit/changes/EntityChangeTest.php
b/lib/tests/phpunit/changes/EntityChangeTest.php
index f9ec8f7..90db7ff 100644
--- a/lib/tests/phpunit/changes/EntityChangeTest.php
+++ b/lib/tests/phpunit/changes/EntityChangeTest.php
@@ -207,17 +207,6 @@
$this->assertEquals( 7, $change->getField( 'user_id' ), 7 );
}
- public function testSetEntityId() {
- $q7 = new ItemId( 'Q7' );
- $q8 = new ItemId( 'Q8' );
-
- $changeFactory = TestChanges::getEntityChangeFactory();
- $change = $changeFactory->newForEntity( EntityChange::UPDATE,
$q7 );
-
- $change->setEntityId( $q8 );
- $this->assertEquals( strtolower( $q8->getSerialization() ),
$change->getObjectId() );
- }
-
public function testSetTimestamp() {
$q7 = new ItemId( 'Q7' );
--
To view, visit https://gerrit.wikimedia.org/r/197874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife61209174ef964a45ac768ef54b94ca64031020
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
